LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [ASoC]fsl_ssi: fix of_property_read_u32_array return value check
@ 2015-02-15 22:11 Maciej S. Szmigiero
  2015-02-24  8:24 ` Mark Brown
  0 siblings, 1 reply; 4+ messages in thread
From: Maciej S. Szmigiero @ 2015-02-15 22:11 UTC (permalink / raw)
  To: alsa-devel, linux-kernel
  Cc: Timur Tabi, Nicolin Chen, Xiubo Li, Liam Girdwood, Mark Brown

of_property_read_u32_array returns 0 on success, so the return value shouldn't be inverted twice,
first on assignment then in condition expression.

Signed-off-by: Maciej Szmigiero <mail@maciej.szmigiero.name>

diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index d7365c5..134388f 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -1227,7 +1227,7 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev,
     ssi_private->dma_params_tx.addr = ssi_private->ssi_phys + CCSR_SSI_STX0;
     ssi_private->dma_params_rx.addr = ssi_private->ssi_phys + CCSR_SSI_SRX0;
 
-    ret = !of_property_read_u32_array(np, "dmas", dmas, 4);
+    ret = of_property_read_u32_array(np, "dmas", dmas, 4);
     if (ssi_private->use_dma && !ret && dmas[2] == IMX_DMATYPE_SSI_DUAL) {
         ssi_private->use_dual_fifo = true;
         /* When using dual fifo mode, we need to keep watermark


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ASoC]fsl_ssi: fix of_property_read_u32_array return value check
  2015-02-15 22:11 [ASoC]fsl_ssi: fix of_property_read_u32_array return value check Maciej S. Szmigiero
@ 2015-02-24  8:24 ` Mark Brown
  2015-03-04 13:07   ` Maciej S. Szmigiero
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2015-02-24  8:24 UTC (permalink / raw)
  To: Maciej S. Szmigiero
  Cc: alsa-devel, linux-kernel, Timur Tabi, Nicolin Chen, Xiubo Li,
	Liam Girdwood

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

On Sun, Feb 15, 2015 at 11:11:43PM +0100, Maciej S. Szmigiero wrote:
> of_property_read_u32_array returns 0 on success, so the return value shouldn't be inverted twice,
> first on assignment then in condition expression.

This doesn't apply to current code, please check and resend.  Please
also keep your changelog under 80 columns as covered in
SubmittingPatches.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ASoC]fsl_ssi: fix of_property_read_u32_array return value check
  2015-02-24  8:24 ` Mark Brown
@ 2015-03-04 13:07   ` Maciej S. Szmigiero
  2015-03-04 17:27     ` Mark Brown
  0 siblings, 1 reply; 4+ messages in thread
From: Maciej S. Szmigiero @ 2015-03-04 13:07 UTC (permalink / raw)
  To: Mark Brown
  Cc: alsa-devel, linux-kernel, Timur Tabi, Nicolin Chen, Xiubo Li,
	Liam Girdwood

W dniu 24.02.2015 09:24, Mark Brown pisze:
> On Sun, Feb 15, 2015 at 11:11:43PM +0100, Maciej S. Szmigiero wrote:
>> of_property_read_u32_array returns 0 on success, so the return value shouldn't be inverted twice,
>> first on assignment then in condition expression.
> 
> This doesn't apply to current code, please check and resend.  Please
> also keep your changelog under 80 columns as covered in
> SubmittingPatches.
> 

Thanks for looking into it,

Against which tree/branch patches for ASoC should be generated?

Best regards,
Maciej Szmigiero


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ASoC]fsl_ssi: fix of_property_read_u32_array return value check
  2015-03-04 13:07   ` Maciej S. Szmigiero
@ 2015-03-04 17:27     ` Mark Brown
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2015-03-04 17:27 UTC (permalink / raw)
  To: Maciej S. Szmigiero
  Cc: alsa-devel, linux-kernel, Timur Tabi, Nicolin Chen, Xiubo Li,
	Liam Girdwood

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

On Wed, Mar 04, 2015 at 02:07:21PM +0100, Maciej S. Szmigiero wrote:

> Against which tree/branch patches for ASoC should be generated?

MAINTAINERS says:

SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEMENT (ASoC)
M:      Liam Girdwood <lgirdwood@gmail.com>
M:      Mark Brown <broonie@kernel.org>
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

mainly the for-next branch, though bugfixes go on for-linus.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-03-04 17:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-15 22:11 [ASoC]fsl_ssi: fix of_property_read_u32_array return value check Maciej S. Szmigiero
2015-02-24  8:24 ` Mark Brown
2015-03-04 13:07   ` Maciej S. Szmigiero
2015-03-04 17:27     ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).