From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758875AbbCDSpF (ORCPT ); Wed, 4 Mar 2015 13:45:05 -0500 Received: from mail-wg0-f44.google.com ([74.125.82.44]:39754 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754366AbbCDSpD (ORCPT ); Wed, 4 Mar 2015 13:45:03 -0500 Date: Wed, 4 Mar 2015 18:44:58 +0000 From: Lee Jones To: Adam Ward Cc: Samuel Ortiz , Support Opensource , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] mfd: da9052: Fix register access via SPI Message-ID: <20150304184458.GN32624@x1> References: <856964c7285656c88f23d0bcd5dae8519c2a1227.1425490309.git.adam.ward.opensource@diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <856964c7285656c88f23d0bcd5dae8519c2a1227.1425490309.git.adam.ward.opensource@diasemi.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 04 Mar 2015, Adam Ward wrote: > The range of registers used by this driver exceeds that available > via SPI with no paging (127), so we have to override the values > from the default config which is set-up for I2C access. > Also change SPI settings to match device's recommended OTP values. > > Signed-off-by: Adam Ward > Tested-by: Adam Ward I'd be worried if you hadn't tested it. In future, Signed-off-by is sufficient. Patch applied, thanks. > --- > drivers/mfd/da9052-spi.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/da9052-spi.c b/drivers/mfd/da9052-spi.c > index 45ae0b7..b5de8a6 100644 > --- a/drivers/mfd/da9052-spi.c > +++ b/drivers/mfd/da9052-spi.c > @@ -32,7 +32,7 @@ static int da9052_spi_probe(struct spi_device *spi) > if (!da9052) > return -ENOMEM; > > - spi->mode = SPI_MODE_0 | SPI_CPOL; > + spi->mode = SPI_MODE_0; > spi->bits_per_word = 8; > spi_setup(spi); > > @@ -43,6 +43,10 @@ static int da9052_spi_probe(struct spi_device *spi) > > config = da9052_regmap_config; > config.read_flag_mask = 1; > + config.reg_bits = 7; > + config.pad_bits = 1; > + config.val_bits = 8; > + config.use_single_rw = 1; > > da9052->regmap = devm_regmap_init_spi(spi, &config); > if (IS_ERR(da9052->regmap)) { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog