LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ken Moffat <zarniwhoop@ntlworld.com>
To: Tiejun Chen <tiejun.chen@intel.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Qemu e1000 broken in -rc1 and -rc2 : bisected
Date: Fri, 6 Mar 2015 19:27:28 +0000	[thread overview]
Message-ID: <20150306192728.GA5032@milliways> (raw)
In-Reply-To: <20150306000240.GA9960@milliways>

On Fri, Mar 06, 2015 at 12:02:40AM +0000, Ken Moffat wrote:
>  I have a very recent qemu i686 image, using a 3.19.0 kernel and
> dhclient, which works fine if the host is running a 3.19.0 kernel,
> but breaks when the host runs 4.0.0-rc1 or -rc2.
> 
>  On those, dhclient does not get an address, so I have no network.
> There is a message
> e1000 0000:00:03.0 eth0: Reset adaptor
> 
>  Before I start trying to bisect this, has anybody already seen, or
> fixed, it ?
> 
 Bisected.
b4eef9b36db461ca44832226fbca614db58c0c33 is the first bad commit
commit b4eef9b36db461ca44832226fbca614db58c0c33
Author: Tiejun Chen <tiejun.chen@intel.com>
Date:   Mon Dec 22 10:32:57 2014 +0100

    kvm: x86: vmx: NULL out hwapic_isr_update() in case of
!enable_apicv
    
    In most cases calling hwapic_isr_update(), we always check if
    kvm_apic_vid_enabled() == 1, but actually,
    kvm_apic_vid_enabled()
        -> kvm_x86_ops->vm_has_apicv()
            -> vmx_vm_has_apicv() or '0' in svm case
                -> return enable_apicv && irqchip_in_kernel(kvm)
    
    So its a little cost to recall vmx_vm_has_apicv() inside
    hwapic_isr_update(), here just NULL out hwapic_isr_update() in
    case of !enable_apicv inside hardware_setup() then make all
    related stuffs follow this. Note we don't check this under that
    condition of irqchip_in_kernel() since we should make sure
    definitely any caller don't work  without in-kernel irqchip.
    
    Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

 I have reverted this from -rc2 (big offsets, 209 and 357 lines) and
everything is working again.

ĸen
-- 
Nanny Ogg usually went to bed early. After all, she was an old lady.
Sometimes she went to bed as early as 6 a.m.

  reply	other threads:[~2015-03-06 19:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06  0:02 Qemu e1000 broken in -rc1 and -rc2 Ken Moffat
2015-03-06 19:27 ` Ken Moffat [this message]
2015-03-09  3:14   ` Qemu e1000 broken in -rc1 and -rc2 : bisected Chen, Tiejun
2015-03-09 15:05     ` Ken Moffat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150306192728.GA5032@milliways \
    --to=zarniwhoop@ntlworld.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=tiejun.chen@intel.com \
    --subject='Re: Qemu e1000 broken in -rc1 and -rc2 : bisected' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).