From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756639AbbCFT2D (ORCPT ); Fri, 6 Mar 2015 14:28:03 -0500 Received: from know-smtprelay-omc-7.server.virginmedia.net ([80.0.253.71]:33553 "EHLO know-smtprelay-omc-7.server.virginmedia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756577AbbCFT1a (ORCPT ); Fri, 6 Mar 2015 14:27:30 -0500 X-Originating-IP: [81.106.150.188] X-Spam: 0 X-Authority: v=2.1 cv=cpwVkjIi c=1 sm=1 tr=0 a=DGj713NdaxKrsjjgQne7PA==:117 a=DGj713NdaxKrsjjgQne7PA==:17 a=J0QyKEt1u0cA:10 a=IkcTkHD0fZMA:10 a=NLZqzBF-AAAA:8 a=emO1SXQWCLwA:10 a=QyXUC8HyAAAA:8 a=20KFwNOVAAAA:8 a=OaitK4vYQ39I1X9uVsgA:9 a=QEXdDO2ut3YA:10 Date: Fri, 6 Mar 2015 19:27:28 +0000 From: Ken Moffat To: Tiejun Chen , Paolo Bonzini Cc: linux-kernel@vger.kernel.org Subject: Re: Qemu e1000 broken in -rc1 and -rc2 : bisected Message-ID: <20150306192728.GA5032@milliways> References: <20150306000240.GA9960@milliways> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150306000240.GA9960@milliways> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 06, 2015 at 12:02:40AM +0000, Ken Moffat wrote: > I have a very recent qemu i686 image, using a 3.19.0 kernel and > dhclient, which works fine if the host is running a 3.19.0 kernel, > but breaks when the host runs 4.0.0-rc1 or -rc2. > > On those, dhclient does not get an address, so I have no network. > There is a message > e1000 0000:00:03.0 eth0: Reset adaptor > > Before I start trying to bisect this, has anybody already seen, or > fixed, it ? > Bisected. b4eef9b36db461ca44832226fbca614db58c0c33 is the first bad commit commit b4eef9b36db461ca44832226fbca614db58c0c33 Author: Tiejun Chen Date: Mon Dec 22 10:32:57 2014 +0100 kvm: x86: vmx: NULL out hwapic_isr_update() in case of !enable_apicv In most cases calling hwapic_isr_update(), we always check if kvm_apic_vid_enabled() == 1, but actually, kvm_apic_vid_enabled() -> kvm_x86_ops->vm_has_apicv() -> vmx_vm_has_apicv() or '0' in svm case -> return enable_apicv && irqchip_in_kernel(kvm) So its a little cost to recall vmx_vm_has_apicv() inside hwapic_isr_update(), here just NULL out hwapic_isr_update() in case of !enable_apicv inside hardware_setup() then make all related stuffs follow this. Note we don't check this under that condition of irqchip_in_kernel() since we should make sure definitely any caller don't work without in-kernel irqchip. Signed-off-by: Tiejun Chen Signed-off-by: Paolo Bonzini I have reverted this from -rc2 (big offsets, 209 and 357 lines) and everything is working again. ĸen -- Nanny Ogg usually went to bed early. After all, she was an old lady. Sometimes she went to bed as early as 6 a.m.