LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] phy: twl4030-usb: Remove redundant assignment for twl->linkstat
@ 2015-03-01 14:28 Axel Lin
  2015-03-09 16:34 ` Felipe Balbi
  0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2015-03-01 14:28 UTC (permalink / raw)
  To: Kishon Vijay Abraham I; +Cc: Felipe Balbi, linux-kernel

It's pointless to set twl->linkstat twice.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/phy/phy-twl4030-usb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c
index 8e87f54..bc42d6a 100644
--- a/drivers/phy/phy-twl4030-usb.c
+++ b/drivers/phy/phy-twl4030-usb.c
@@ -666,7 +666,6 @@ static int twl4030_usb_probe(struct platform_device *pdev)
 	twl->dev		= &pdev->dev;
 	twl->irq		= platform_get_irq(pdev, 0);
 	twl->vbus_supplied	= false;
-	twl->linkstat		= -EINVAL;
 	twl->linkstat		= OMAP_MUSB_UNKNOWN;
 
 	twl->phy.dev		= twl->dev;
-- 
1.9.1




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] phy: twl4030-usb: Remove redundant assignment for twl->linkstat
  2015-03-01 14:28 [PATCH] phy: twl4030-usb: Remove redundant assignment for twl->linkstat Axel Lin
@ 2015-03-09 16:34 ` Felipe Balbi
  0 siblings, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2015-03-09 16:34 UTC (permalink / raw)
  To: Axel Lin; +Cc: Kishon Vijay Abraham I, Felipe Balbi, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

On Sun, Mar 01, 2015 at 10:28:23PM +0800, Axel Lin wrote:
> It's pointless to set twl->linkstat twice.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

please resend with linux-usb in Cc

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] phy: twl4030-usb: Remove redundant assignment for twl->linkstat
@ 2015-03-10  1:22 Axel Lin
  0 siblings, 0 replies; 3+ messages in thread
From: Axel Lin @ 2015-03-10  1:22 UTC (permalink / raw)
  To: Kishon Vijay Abraham I; +Cc: Felipe Balbi, linux-kernel, linux-usb

It's pointless to set twl->linkstat twice.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Resend with linux-usb in Cc.
 drivers/phy/phy-twl4030-usb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c
index 8e87f54..bc42d6a 100644
--- a/drivers/phy/phy-twl4030-usb.c
+++ b/drivers/phy/phy-twl4030-usb.c
@@ -666,7 +666,6 @@ static int twl4030_usb_probe(struct platform_device *pdev)
 	twl->dev		= &pdev->dev;
 	twl->irq		= platform_get_irq(pdev, 0);
 	twl->vbus_supplied	= false;
-	twl->linkstat		= -EINVAL;
 	twl->linkstat		= OMAP_MUSB_UNKNOWN;
 
 	twl->phy.dev		= twl->dev;
-- 
1.9.1




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-10  1:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-01 14:28 [PATCH] phy: twl4030-usb: Remove redundant assignment for twl->linkstat Axel Lin
2015-03-09 16:34 ` Felipe Balbi
2015-03-10  1:22 Axel Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).