LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ASoC: wm5100: match wait_for_completion_timeout return type
@ 2015-03-08 10:57 Nicholas Mc Guire
  2015-03-08 18:49 ` Mark Brown
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Nicholas Mc Guire @ 2015-03-08 10:57 UTC (permalink / raw)
  To: Liam Girdwood
  Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Lars-Peter Clausen,
	Charles Keepax, Tomi Valkeinen, Xiubo Li, Rafael J. Wysocki,
	Axel Lin, abdoulaye berthe, patches, alsa-devel, linux-kernel,
	Nicholas Mc Guire

return type of wait_for_completion_timeout is unsigned long not int. An
appropriately named unsigned long is added and the assignment fixed up.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---

This was only compile tested for exynos_defconfig + CONFIG_COMPILE_TEST=y,
SND_SOC_ALL_CODECS=m (implies CONFIG_SND_SOC_WM5100=m)

Patch is against 4.0-rc2 linux-next (localversion-next is -next-20150306)

 sound/soc/codecs/wm5100.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c
index ea09db5..9674037 100644
--- a/sound/soc/codecs/wm5100.c
+++ b/sound/soc/codecs/wm5100.c
@@ -1762,6 +1762,7 @@ static int wm5100_set_fll(struct snd_soc_codec *codec, int fll_id, int source,
 	struct _fll_div factors;
 	struct wm5100_fll *fll;
 	int ret, base, lock, i, timeout;
+	unsigned long time_left;
 
 	switch (fll_id) {
 	case WM5100_FLL1:
@@ -1842,9 +1843,9 @@ static int wm5100_set_fll(struct snd_soc_codec *codec, int fll_id, int source,
 	/* Poll for the lock; will use interrupt when we can test */
 	for (i = 0; i < timeout; i++) {
 		if (i2c->irq) {
-			ret = wait_for_completion_timeout(&fll->lock,
-							  msecs_to_jiffies(25));
-			if (ret > 0)
+			time_left = wait_for_completion_timeout(&fll->lock,
+							msecs_to_jiffies(25));
+			if (time_left > 0)
 				break;
 		} else {
 			msleep(1);
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: wm5100: match wait_for_completion_timeout return type
  2015-03-08 10:57 [PATCH] ASoC: wm5100: match wait_for_completion_timeout return type Nicholas Mc Guire
@ 2015-03-08 18:49 ` Mark Brown
  2015-03-09  6:22   ` Nicholas Mc Guire
  2015-03-09 14:29 ` Charles Keepax
  2015-03-09 18:16 ` Mark Brown
  2 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2015-03-08 18:49 UTC (permalink / raw)
  To: Nicholas Mc Guire
  Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Lars-Peter Clausen,
	Charles Keepax, Tomi Valkeinen, Xiubo Li, Rafael J. Wysocki,
	Axel Lin, abdoulaye berthe, patches, alsa-devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

On Sun, Mar 08, 2015 at 06:57:07AM -0400, Nicholas Mc Guire wrote:
> return type of wait_for_completion_timeout is unsigned long not int. An
> appropriately named unsigned long is added and the assignment fixed up.

You are sending these to a very large CC list many of whom have no
obvious connection to the driver - please take care to ensure that the
people you are sending patches to are likely to want to review the code,
this helps keep people's mailboxes less noisy.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: wm5100: match wait_for_completion_timeout return type
  2015-03-08 18:49 ` Mark Brown
@ 2015-03-09  6:22   ` Nicholas Mc Guire
  2015-03-09 11:26     ` Mark Brown
  0 siblings, 1 reply; 6+ messages in thread
From: Nicholas Mc Guire @ 2015-03-09  6:22 UTC (permalink / raw)
  To: Mark Brown
  Cc: Nicholas Mc Guire, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
	Lars-Peter Clausen, Charles Keepax, Tomi Valkeinen, Xiubo Li,
	Rafael J. Wysocki, Axel Lin, abdoulaye berthe, patches,
	alsa-devel, linux-kernel

On Sun, 08 Mar 2015, Mark Brown wrote:

> On Sun, Mar 08, 2015 at 06:57:07AM -0400, Nicholas Mc Guire wrote:
> > return type of wait_for_completion_timeout is unsigned long not int. An
> > appropriately named unsigned long is added and the assignment fixed up.
> 
> You are sending these to a very large CC list many of whom have no
> obvious connection to the driver - please take care to ensure that the
> people you are sending patches to are likely to want to review the code,
> this helps keep people's mailboxes less noisy.

sorry if I messed that up - my understanding was that
it should go out to all that scripts/get_mainteiner.pl shows
for the espective file. Should some of those listed
not be put on the CC list - or only maintainers+mailinglists ?

thx!
hofrat

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: wm5100: match wait_for_completion_timeout return type
  2015-03-09  6:22   ` Nicholas Mc Guire
@ 2015-03-09 11:26     ` Mark Brown
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2015-03-09 11:26 UTC (permalink / raw)
  To: Nicholas Mc Guire
  Cc: Nicholas Mc Guire, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
	Lars-Peter Clausen, Charles Keepax, Tomi Valkeinen, Xiubo Li,
	Rafael J. Wysocki, Axel Lin, abdoulaye berthe, patches,
	alsa-devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

On Mon, Mar 09, 2015 at 07:22:26AM +0100, Nicholas Mc Guire wrote:
> On Sun, 08 Mar 2015, Mark Brown wrote:

> > You are sending these to a very large CC list many of whom have no
> > obvious connection to the driver - please take care to ensure that the
> > people you are sending patches to are likely to want to review the code,
> > this helps keep people's mailboxes less noisy.

> sorry if I messed that up - my understanding was that
> it should go out to all that scripts/get_mainteiner.pl shows
> for the espective file. Should some of those listed
> not be put on the CC list - or only maintainers+mailinglists ?

No, if you're doing that based on the --git option it'll typically get a
lot of false positives for people doing coe cleanups for things.
Without git it's a bit more reliable but may miss people who work on the
code but aren't in MAINTAINERS.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: wm5100: match wait_for_completion_timeout return type
  2015-03-08 10:57 [PATCH] ASoC: wm5100: match wait_for_completion_timeout return type Nicholas Mc Guire
  2015-03-08 18:49 ` Mark Brown
@ 2015-03-09 14:29 ` Charles Keepax
  2015-03-09 18:16 ` Mark Brown
  2 siblings, 0 replies; 6+ messages in thread
From: Charles Keepax @ 2015-03-09 14:29 UTC (permalink / raw)
  To: Nicholas Mc Guire
  Cc: Liam Girdwood, Mark Brown, patches, alsa-devel, linux-kernel

On Sun, Mar 08, 2015 at 06:57:07AM -0400, Nicholas Mc Guire wrote:
> return type of wait_for_completion_timeout is unsigned long not int. An
> appropriately named unsigned long is added and the assignment fixed up.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: wm5100: match wait_for_completion_timeout return type
  2015-03-08 10:57 [PATCH] ASoC: wm5100: match wait_for_completion_timeout return type Nicholas Mc Guire
  2015-03-08 18:49 ` Mark Brown
  2015-03-09 14:29 ` Charles Keepax
@ 2015-03-09 18:16 ` Mark Brown
  2 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2015-03-09 18:16 UTC (permalink / raw)
  To: Nicholas Mc Guire
  Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Lars-Peter Clausen,
	Charles Keepax, Tomi Valkeinen, Xiubo Li, Rafael J. Wysocki,
	Axel Lin, abdoulaye berthe, patches, alsa-devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

On Sun, Mar 08, 2015 at 06:57:07AM -0400, Nicholas Mc Guire wrote:
> return type of wait_for_completion_timeout is unsigned long not int. An
> appropriately named unsigned long is added and the assignment fixed up.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-03-09 18:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-08 10:57 [PATCH] ASoC: wm5100: match wait_for_completion_timeout return type Nicholas Mc Guire
2015-03-08 18:49 ` Mark Brown
2015-03-09  6:22   ` Nicholas Mc Guire
2015-03-09 11:26     ` Mark Brown
2015-03-09 14:29 ` Charles Keepax
2015-03-09 18:16 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).