From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752067AbbCJG3C (ORCPT ); Tue, 10 Mar 2015 02:29:02 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:45101 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751927AbbCJG3A (ORCPT ); Tue, 10 Mar 2015 02:29:00 -0400 Date: Mon, 9 Mar 2015 23:28:52 -0700 From: Brian Norris To: Frans Klaver Cc: David Woodhouse , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH 30/60] mtd: nand: fsl_elbc_nand: show device in sysfs Message-ID: <20150310062852.GA4124@norris-Latitude-E6410> References: <1425418844-25177-1-git-send-email-fransklaver@gmail.com> <1425418844-25177-31-git-send-email-fransklaver@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425418844-25177-31-git-send-email-fransklaver@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 03, 2015 at 10:40:14PM +0100, Frans Klaver wrote: > Fix a bug where devices aren't shown in sysfs. > > While at it, make use of the default owner value set by mtdcore. > > Signed-off-by: Frans Klaver > --- > drivers/mtd/nand/fsl_elbc_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c > index 04b22fd..0cd94a1 100644 > --- a/drivers/mtd/nand/fsl_elbc_nand.c > +++ b/drivers/mtd/nand/fsl_elbc_nand.c > @@ -747,7 +747,7 @@ static int fsl_elbc_chip_init(struct fsl_elbc_mtd *priv) > > /* Fill in fsl_elbc_mtd structure */ > priv->mtd.priv = chip; > - priv->mtd.owner = THIS_MODULE; > + priv->mtd.dev.parent = &chip->dev; drivers/mtd/nand/fsl_elbc_nand.c: In function 'fsl_elbc_chip_init': drivers/mtd/nand/fsl_elbc_nand.c:750:30: error: 'struct nand_chip' has no member named 'dev' make[4]: *** [drivers/mtd/nand/fsl_elbc_nand.o] Error 1 > > /* set timeout to maximum */ > priv->fmr = 15 << FMR_CWTO_SHIFT; > -- > 2.2.2 >