From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751562AbbCJHjn (ORCPT ); Tue, 10 Mar 2015 03:39:43 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:26783 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbbCJHjl (ORCPT ); Tue, 10 Mar 2015 03:39:41 -0400 Date: Tue, 10 Mar 2015 10:39:13 +0300 From: Dan Carpenter To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= Cc: lidza.louina@gmail.com, markh@compro.net, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize Message-ID: <20150310073913.GO10964@mwanda> References: <1425918578-10223-1-git-send-email-giedrius.statkevicius@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1425918578-10223-1-git-send-email-giedrius.statkevicius@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote: > Remove BOARD_FAILED and don't save dgnc_boards which failed to > initialize. > > Assign the result of kzalloc() to brd in dgnc_found_board() and only put > it in the dgnc_Board[] if it successfully initializes. Also, remove > BOARD_FAILED enum and all ifs that check for it. Finally, remove one > final place where state was set to BOARD_FAILED which was even redundant > before this patch. > > Signed-off-by: Giedrius Statkevičius Great! Very thourough. Thanks. :) regards, dan carpenter