From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752813AbbCJLGr (ORCPT ); Tue, 10 Mar 2015 07:06:47 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:33684 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751616AbbCJLGp (ORCPT ); Tue, 10 Mar 2015 07:06:45 -0400 Date: Tue, 10 Mar 2015 11:06:38 +0000 From: Mark Brown To: "Ivan T. Ivanov" Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Message-ID: <20150310110638.GD28806@sirena.org.uk> References: <1425655578-22400-1-git-send-email-iivanov@mm-sol.com> <1425655578-22400-2-git-send-email-iivanov@mm-sol.com> <20150307105948.GD28806@sirena.org.uk> <1425889415.2440.10.camel@mm-sol.com> <20150309182841.GW28806@sirena.org.uk> <1425975056.2440.24.camel@mm-sol.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Jm4NjHtWXfjOIegD" Content-Disposition: inline In-Reply-To: <1425975056.2440.24.camel@mm-sol.com> X-Cookie: Editing is a rewording activity. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Jm4NjHtWXfjOIegD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 10, 2015 at 10:10:56AM +0200, Ivan T. Ivanov wrote: > On Mon, 2015-03-09 at 18:28 +0000, Mark Brown wrote: > > > About the API usage, point taken. GPIO requesting part is more import= ant > > > in this case. pinctrl core did not request pins and wrong DT configur= ation > > > could lead to surprises without any warnings or errors. > > That doesn't answer my concern at all. > I am not sure that I am following you.=20 > I can not use spi_master::cs_gpios, which is populated by=20 > of_spi_register_master(), because spi_register_master()=20 > populate SPI devices and they could issue setup method. I'm sorry but I can't parse the above. What does "they could issue setup method" mean and why is it a problem? > Requesting GPIO's in core framework is also not a easy > option because of arguments here[1]. We should really fix that though. --Jm4NjHtWXfjOIegD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJU/tA9AAoJECTWi3JdVIfQY+0H/1Q2KzHpIrD75lH/krD1TF2i cvzpY3BlNSFDsI8hX7cPEG1UxxfzUfpPElH/KQ2pJNEITuXX9AFwPnmxmDRbe8zc 7UESjKKZjdEzRxp+NmB57U8FyGF9wrSaiY62lRRWoSjWXA6tE+QeaKIKE8KLwoIg U9vyPTHzqcLaL4yrs1nlLnc67kaUOV4i/DagzdVZ60EHv59Mg4nIp+BTUBjnPkjC Fje2o/R7DjTfaWEE8uIrlYFS8NN/dUGfYZ+IPadvV5ex0sUWInge5fyvdnCiBk1h oa8LHqm+wmjJjnqBJldj6joHjqqdLur/RenlffdOHGvs1aMvemhJWLiWHwBYUh0= =Cb0p -----END PGP SIGNATURE----- --Jm4NjHtWXfjOIegD--