LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Heiko Stuebner <heiko@sntech.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] driver core: Make probe deferral more quiet
Date: Tue, 10 Mar 2015 05:57:41 -0700	[thread overview]
Message-ID: <20150310125741.GS26334@sonymobile.com> (raw)
In-Reply-To: <1425988549-12310-1-git-send-email-broonie@kernel.org>

On Tue 10 Mar 04:55 PDT 2015, Mark Brown wrote:

> Currently probe deferral prints a message every time a device requests
> deferral at info severity (which is displayed by default). This can have
> an impact on system boot times with serial consoles and is generally quite
> noisy.
> 
> Since subsystems and drivers should already be logging the specific reason
> for probe deferral in order to aid users in understanding problems the
> messages from the driver core should be redundant lower the severity of
> the messages printed, cutting down on the volume of output on the console.
> 
> This does mean that if the drivers and subsystems aren't doing a good job
> we get no output on the console by default. Ideally we'd be able to arrange
> to print if nothing else printed, though that's a little fun. Even better
> would be to come up with a mechanism that explicitly does dependencies so
> we don't have to keep polling and erroring.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

I like it, much better than the suggestion I made to drop the more
informative print out in the regulator framework.

Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>

Regards,
Bjorn

      reply	other threads:[~2015-03-10 12:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10 11:55 Mark Brown
2015-03-10 12:57 ` Bjorn Andersson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150310125741.GS26334@sonymobile.com \
    --to=bjorn.andersson@sonymobile.com \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] driver core: Make probe deferral more quiet' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).