LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] driver core: Make probe deferral more quiet
@ 2015-03-10 11:55 Mark Brown
  2015-03-10 12:57 ` Bjorn Andersson
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2015-03-10 11:55 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Heiko Stuebner, Bjorn Andersson, linux-kernel, Mark Brown

Currently probe deferral prints a message every time a device requests
deferral at info severity (which is displayed by default). This can have
an impact on system boot times with serial consoles and is generally quite
noisy.

Since subsystems and drivers should already be logging the specific reason
for probe deferral in order to aid users in understanding problems the
messages from the driver core should be redundant lower the severity of
the messages printed, cutting down on the volume of output on the console.

This does mean that if the drivers and subsystems aren't doing a good job
we get no output on the console by default. Ideally we'd be able to arrange
to print if nothing else printed, though that's a little fun. Even better
would be to come up with a mechanism that explicitly does dependencies so
we don't have to keep polling and erroring.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/base/dd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index cdc779cf79a3..a3abe628aa8d 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -322,7 +322,7 @@ probe_failed:
 
 	if (ret == -EPROBE_DEFER) {
 		/* Driver requested deferred probing */
-		dev_info(dev, "Driver %s requests probe deferral\n", drv->name);
+		dev_dbg(dev, "Driver %s requests probe deferral\n", drv->name);
 		driver_deferred_probe_add(dev);
 		/* Did a trigger occur while probing? Need to re-trigger if yes */
 		if (local_trigger_count != atomic_read(&deferred_trigger_count))
-- 
2.1.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] driver core: Make probe deferral more quiet
  2015-03-10 11:55 [PATCH] driver core: Make probe deferral more quiet Mark Brown
@ 2015-03-10 12:57 ` Bjorn Andersson
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2015-03-10 12:57 UTC (permalink / raw)
  To: Mark Brown; +Cc: Greg Kroah-Hartman, Heiko Stuebner, linux-kernel

On Tue 10 Mar 04:55 PDT 2015, Mark Brown wrote:

> Currently probe deferral prints a message every time a device requests
> deferral at info severity (which is displayed by default). This can have
> an impact on system boot times with serial consoles and is generally quite
> noisy.
> 
> Since subsystems and drivers should already be logging the specific reason
> for probe deferral in order to aid users in understanding problems the
> messages from the driver core should be redundant lower the severity of
> the messages printed, cutting down on the volume of output on the console.
> 
> This does mean that if the drivers and subsystems aren't doing a good job
> we get no output on the console by default. Ideally we'd be able to arrange
> to print if nothing else printed, though that's a little fun. Even better
> would be to come up with a mechanism that explicitly does dependencies so
> we don't have to keep polling and erroring.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

I like it, much better than the suggestion I made to drop the more
informative print out in the regulator framework.

Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>

Regards,
Bjorn

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-10 12:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-10 11:55 [PATCH] driver core: Make probe deferral more quiet Mark Brown
2015-03-10 12:57 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).