LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] serial: mxs-auart: fix build failure due to broken goto statement 
@ 2015-03-10 17:57 Nicholas Mc Guire
  2015-03-10 19:45 ` Uwe Kleine-König
  0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Mc Guire @ 2015-03-10 17:57 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Jiri Slaby, Uwe Kleine-K?nig, Janusz Uzycki, linux-serial,
	linux-next, linux-kernel, Nicholas Mc Guire

fix mxs-auart build failure. got -> goto and wrong jump target.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---

Seems this was introduced in 343fda95481a ("serial: mxs-auart: properly handle 
mctrl_gpio failing")

This was only compile tested for mxs_defconfig

Patch is against 4.0-rc3 (localversion-next is -next-20150310)

 drivers/tty/serial/mxs-auart.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
index 9abdccf..a17abca 100644
--- a/drivers/tty/serial/mxs-auart.c
+++ b/drivers/tty/serial/mxs-auart.c
@@ -1279,7 +1279,7 @@ static int mxs_auart_probe(struct platform_device *pdev)
 	ret = mxs_auart_init_gpios(s, &pdev->dev);
 	if (ret) {
 		dev_err(&pdev->dev, "Failed to initialize GPIOs.\n");
-		got out_free_irq;
+		goto out_free_gpio_irq;
 	}
 
 	/*
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] serial: mxs-auart: fix build failure due to broken goto statement
  2015-03-10 17:57 [PATCH] serial: mxs-auart: fix build failure due to broken goto statement Nicholas Mc Guire
@ 2015-03-10 19:45 ` Uwe Kleine-König
  0 siblings, 0 replies; 2+ messages in thread
From: Uwe Kleine-König @ 2015-03-10 19:45 UTC (permalink / raw)
  To: Nicholas Mc Guire
  Cc: Greg Kroah-Hartman, Jiri Slaby, Janusz Uzycki, linux-serial,
	linux-next, linux-kernel

Hello,

On Tue, Mar 10, 2015 at 01:57:57PM -0400, Nicholas Mc Guire wrote:
> fix mxs-auart build failure. got -> goto and wrong jump target.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fabio was bit quicker than you. He sent the same patch just before you
with Message-Id: 1425997464-3422-1-git-send-email-fabio.estevam@freescale.com.

I failed to find a working archive though.

Thanks anyhow,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-10 19:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-10 17:57 [PATCH] serial: mxs-auart: fix build failure due to broken goto statement Nicholas Mc Guire
2015-03-10 19:45 ` Uwe Kleine-König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).