LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ion: improve ion_phys error message
@ 2015-03-10 17:08 Mitchel Humpherys
2015-03-10 20:46 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Mitchel Humpherys @ 2015-03-10 17:08 UTC (permalink / raw)
To: devel, Android Kernel Team, Colin Cross
Cc: linux-kernel, John Stultz, Dan Carpenter, Mitchel Humpherys
Clients often get confused when ion_phys errors out due to some heap
being used that they didn't expect. Add the heap name and heap type to
the error message to make it more obvious.
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>
---
drivers/staging/android/ion/ion.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 296d347660fc..966b7fdc9ecf 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -566,8 +566,8 @@ int ion_phys(struct ion_client *client, struct ion_handle *handle,
buffer = handle->buffer;
if (!buffer->heap->ops->phys) {
- pr_err("%s: ion_phys is not implemented by this heap.\n",
- __func__);
+ pr_err("%s: ion_phys is not implemented by this heap (name=%s, type=%d).\n",
+ __func__, buffer->heap->name, buffer->heap->type);
mutex_unlock(&client->lock);
return -ENODEV;
}
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ion: improve ion_phys error message
2015-03-10 17:08 [PATCH] ion: improve ion_phys error message Mitchel Humpherys
@ 2015-03-10 20:46 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-03-10 20:46 UTC (permalink / raw)
To: Mitchel Humpherys
Cc: devel, Android Kernel Team, Colin Cross, John Stultz, linux-kernel
On Tue, Mar 10, 2015 at 10:08:48AM -0700, Mitchel Humpherys wrote:
> Clients often get confused when ion_phys errors out due to some heap
> being used that they didn't expect. Add the heap name and heap type to
> the error message to make it more obvious.
>
> Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>
Hm... You sent this exact same patch a month ago. I'm not sure what
went wrong. You should probably CC Greg next time. It looks ok to me.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ion: improve ion_phys error message
@ 2015-02-14 2:05 Mitchel Humpherys
0 siblings, 0 replies; 3+ messages in thread
From: Mitchel Humpherys @ 2015-02-14 2:05 UTC (permalink / raw)
To: devel, Android Kernel Team, Colin Cross
Cc: linux-kernel, Laura Abbott, John Stultz, Mitchel Humpherys
Clients often get confused when ion_phys errors out due to some heap
being used that they didn't expect. Add the heap name and heap type to
the error message to make it more obvious.
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>
---
drivers/staging/android/ion/ion.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 296d347660fc..966b7fdc9ecf 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -566,8 +566,8 @@ int ion_phys(struct ion_client *client, struct ion_handle *handle,
buffer = handle->buffer;
if (!buffer->heap->ops->phys) {
- pr_err("%s: ion_phys is not implemented by this heap.\n",
- __func__);
+ pr_err("%s: ion_phys is not implemented by this heap (name=%s, type=%d).\n",
+ __func__, buffer->heap->name, buffer->heap->type);
mutex_unlock(&client->lock);
return -ENODEV;
}
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-10 20:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-10 17:08 [PATCH] ion: improve ion_phys error message Mitchel Humpherys
2015-03-10 20:46 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2015-02-14 2:05 Mitchel Humpherys
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).