From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753361AbbCJV5F (ORCPT ); Tue, 10 Mar 2015 17:57:05 -0400 Received: from 251.110.2.81.in-addr.arpa ([81.2.110.251]:46412 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752461AbbCJV5C (ORCPT ); Tue, 10 Mar 2015 17:57:02 -0400 Date: Tue, 10 Mar 2015 21:56:13 +0000 From: One Thousand Gnomes To: Pavel Machek , greg@kroah.com Cc: kernel list , linux-pcmcia@lists.infradead.org, axboe@kernel.dk Subject: Re: [solution exits] no PCMCIA in 4.0-rc3 Message-ID: <20150310215613.3bf7913b@lxorguk.ukuu.org.uk> In-Reply-To: <20150310203158.GA16375@amd> References: <20150227230852.GA21721@amd> <20150302115725.53baae2f@lxorguk.ukuu.org.uk> <20150310203158.GA16375@amd> Organization: Intel Corporation X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Mar 2015 21:31:58 +0100 > > Probably a PCMCIA not a block layer change - well I guess could be > > either. I fixed a pile of PCMCIA bugs and also reworked the allocator for > > pure PCI boxes so it didn't do various bad things. > > > > Can you tweak drivers/pcmcia/Kconfig for config YENTA and make > > > > select PCCARD_PCI if PCMCIA !=n && !ISA > > > > instead do > > > > select PCCARD_NONSTATIC if PCMCIA !=n && !ISA > > > > rebuild and re-test > > If I do that, it breaks compile. If I do that, and delete "config > PCCARD_PCI", it fixes PCMCIA. Thanks! Greg - can you revert commit 02b03846bb2befc558bfd0665749d6bb26f4c2f1 Author: Alan Cox Date: Wed Dec 10 15:07:36 2014 +0000 pcmcia: add a new resource manager for non ISA systems On a pure PCI platform we don't actually need all the complexity of the rsrc_nonstatic manager, in fact we can just work directly with the pci allocators and avoid all the complexity (and code bloat). Signed-off-by: Alan Cox Signed-off-by: Greg Kroah-Hartman and the one on top of it commit d885d4f3728f386034bb2f7a61b7f2054c49b2d4 Author: Arnd Bergmann Date: Tue Jan 13 15:11:55 2015 +0100 pcmcia: add missing include for new pci resource handler The recently added rsrc_pci.c file calls pci_bus_alloc_resource without including the header file that declares it, and that sometimes causes a build warning on ARM: drivers/pcmcia/rsrc_pci.c: In function 'find_io_region': drivers/pcmcia/rsrc_pci.c:40:2: error: implicit declaration of function 'pci_bus_alloc_resource' [-Werror=implicit-function-declaration] This adds the missing include statement. Signed-off-by: Arnd Bergmann Fixes: 02b03846bb2be ("pcmcia: add a new resource manager for non ISA systems") Acked-by: Alan Cox Reported-by: Jim Davis Signed-off-by: Greg Kroah-Hartman as it seems there is a regression in there for some configuration of I/O based devices. I'll take a look at it over the next couple of kernel releases and see what is up then resubmit it with fixes.