LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: akpm@linux-foundation.org, tranmanphong@gmail.com,
	mpe@ellerman.id.au, linux-kernel@vger.kernel.org,
	linux-api@vger.kernel.org
Subject: Re: [PATCH 3/3] selftests: kcmp build fails when invoked from kselftest target
Date: Wed, 11 Mar 2015 01:09:54 +0300	[thread overview]
Message-ID: <20150310220954.GL30296@moon> (raw)
In-Reply-To: <80f321919d8d1f804c4933acac9b044d4c6626eb.1426022048.git.shuahkh@osg.samsung.com>

On Tue, Mar 10, 2015 at 04:00:59PM -0600, Shuah Khan wrote:
> kcmp Makefile doesn't have an explicit build rule. As a result,
> kcmp build fails, when it is run from top level Makefile target
> kselftest. Without the explicit rule, make works only when it is
> run in the current directory or from selftests directory. Add an
> explicit build rule to fix the problem. In addition, build fails
> as it can't find kcmp.h. Fix it by passing CFLAGS.
> 
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>  tools/testing/selftests/kcmp/Makefile | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile
> index ff0eefd..83383eb 100644
> --- a/tools/testing/selftests/kcmp/Makefile
> +++ b/tools/testing/selftests/kcmp/Makefile
> @@ -1,7 +1,8 @@
>  CC := $(CROSS_COMPILE)$(CC)
> -CFLAGS += -I../../../../usr/include/
> +CFLAGS += -I../../../../include/uapi -I../../../../usr/include/
>  
> -all: kcmp_test
> +all:
> +	$(CC) $(CFLAGS) kcmp_test.c -o kcmp_test
>  
>  run_tests: all
>  	@./kcmp_test || echo "kcmp_test: [FAIL]"

Ho Shuah! Thanks for looking into it. I've a small question --
why kcmp_test prerequsite is dropped? As to me it should remain
here, except explicit build rule added.

  reply	other threads:[~2015-03-10 22:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10 22:00 [PATCH 0/3] selftests: ptrace, kcmp, efivars build failure fixes Shuah Khan
2015-03-10 22:00 ` [PATCH 1/3] selftests: ptrace build fails when invoked from kselftest target Shuah Khan
2015-03-10 22:00 ` [PATCH 2/3] selftests: efivars " Shuah Khan
2015-03-10 22:00 ` [PATCH 3/3] selftests: kcmp " Shuah Khan
2015-03-10 22:09   ` Cyrill Gorcunov [this message]
2015-03-10 22:41     ` Shuah Khan
2015-03-10 22:45       ` Cyrill Gorcunov
2015-03-10 23:35 ` [PATCH 0/3] selftests: ptrace, kcmp, efivars build failure fixes Michael Ellerman
2015-03-10 23:37   ` Shuah Khan
2015-03-10 23:40     ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150310220954.GL30296@moon \
    --to=gorcunov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=shuahkh@osg.samsung.com \
    --cc=tranmanphong@gmail.com \
    --subject='Re: [PATCH 3/3] selftests: kcmp build fails when invoked from kselftest target' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).