From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753397AbbCJWKE (ORCPT ); Tue, 10 Mar 2015 18:10:04 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:45399 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752311AbbCJWJ5 (ORCPT ); Tue, 10 Mar 2015 18:09:57 -0400 Date: Wed, 11 Mar 2015 01:09:54 +0300 From: Cyrill Gorcunov To: Shuah Khan Cc: akpm@linux-foundation.org, tranmanphong@gmail.com, mpe@ellerman.id.au, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 3/3] selftests: kcmp build fails when invoked from kselftest target Message-ID: <20150310220954.GL30296@moon> References: <80f321919d8d1f804c4933acac9b044d4c6626eb.1426022048.git.shuahkh@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <80f321919d8d1f804c4933acac9b044d4c6626eb.1426022048.git.shuahkh@osg.samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 04:00:59PM -0600, Shuah Khan wrote: > kcmp Makefile doesn't have an explicit build rule. As a result, > kcmp build fails, when it is run from top level Makefile target > kselftest. Without the explicit rule, make works only when it is > run in the current directory or from selftests directory. Add an > explicit build rule to fix the problem. In addition, build fails > as it can't find kcmp.h. Fix it by passing CFLAGS. > > Signed-off-by: Shuah Khan > --- > tools/testing/selftests/kcmp/Makefile | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile > index ff0eefd..83383eb 100644 > --- a/tools/testing/selftests/kcmp/Makefile > +++ b/tools/testing/selftests/kcmp/Makefile > @@ -1,7 +1,8 @@ > CC := $(CROSS_COMPILE)$(CC) > -CFLAGS += -I../../../../usr/include/ > +CFLAGS += -I../../../../include/uapi -I../../../../usr/include/ > > -all: kcmp_test > +all: > + $(CC) $(CFLAGS) kcmp_test.c -o kcmp_test > > run_tests: all > @./kcmp_test || echo "kcmp_test: [FAIL]" Ho Shuah! Thanks for looking into it. I've a small question -- why kcmp_test prerequsite is dropped? As to me it should remain here, except explicit build rule added.