From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752325AbbCLBZs (ORCPT ); Wed, 11 Mar 2015 21:25:48 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54534 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751415AbbCLBZr (ORCPT ); Wed, 11 Mar 2015 21:25:47 -0400 Date: Wed, 11 Mar 2015 21:25:45 -0400 (EDT) Message-Id: <20150311.212545.1595223451693204245.davem@davemloft.net> To: alexey.kodanev@oracle.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, vasily.isaenko@oracle.com Subject: Re: [PATCH] net: sysctl_net_core: check SNDBUF and RCVBUF for min length From: David Miller In-Reply-To: <1426073357-6211-1-git-send-email-alexey.kodanev@oracle.com> References: <1426073357-6211-1-git-send-email-alexey.kodanev@oracle.com> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexey Kodanev Date: Wed, 11 Mar 2015 14:29:17 +0300 > sysctl has sysctl.net.core.rmem_*/wmem_* parameters which can be > set to incorrect values. Given that 'struct sk_buff' allocates from > rcvbuf, incorrectly set buffer length could result to memory > allocation failures. For example, set them as follows: > > # sysctl net.core.rmem_default=64 > net.core.wmem_default = 64 > # sysctl net.core.wmem_default=64 > net.core.wmem_default = 64 > # ping localhost -s 1024 -i 0 > /dev/null > > This could result to the following failure: ... > Signed-off-by: Alexey Kodanev Applied, but someone needs to followup with fixes to AF_UNIX etc.