LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] pwm: atmel-hlcdc: add errata handling for sama5d4
@ 2015-02-20 15:58 Nicolas Ferre
  2015-02-20 16:06 ` Boris Brezillon
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Ferre @ 2015-02-20 15:58 UTC (permalink / raw)
  To: linux-arm-kernel, thierry.reding, linux-pwm
  Cc: Boris BREZILLON, linux-kernel, Alexandre Belloni, Nicolas Ferre

sama5d4 SoC also has an errata on the HLCDC PWM. It is the same as the sama5d3
that is forbidding the use of div1 prescaler.

Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
 drivers/pwm/pwm-atmel-hlcdc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
index 522f7075bb1a..fa5feaba25a5 100644
--- a/drivers/pwm/pwm-atmel-hlcdc.c
+++ b/drivers/pwm/pwm-atmel-hlcdc.c
@@ -225,6 +225,10 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = {
 		.compatible = "atmel,sama5d3-hlcdc",
 		.data = &atmel_hlcdc_pwm_sama5d3_errata,
 	},
+	{
+		.compatible = "atmel,sama5d4-hlcdc",
+		.data = &atmel_hlcdc_pwm_sama5d3_errata,
+	},
 	{ /* sentinel */ },
 };
 
-- 
2.1.3


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pwm: atmel-hlcdc: add errata handling for sama5d4
  2015-02-20 15:58 [PATCH] pwm: atmel-hlcdc: add errata handling for sama5d4 Nicolas Ferre
@ 2015-02-20 16:06 ` Boris Brezillon
  2015-02-20 16:26   ` Nicolas Ferre
  0 siblings, 1 reply; 4+ messages in thread
From: Boris Brezillon @ 2015-02-20 16:06 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: linux-arm-kernel, thierry.reding, linux-pwm, linux-kernel,
	Alexandre Belloni

Hi Nicolas,

On Fri, 20 Feb 2015 16:58:18 +0100
Nicolas Ferre <nicolas.ferre@atmel.com> wrote:

> sama5d4 SoC also has an errata on the HLCDC PWM. It is the same as the sama5d3
> that is forbidding the use of div1 prescaler.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>

The "atmel,sama5d4-hlcdc" compatible string is not yet documented in
the atmel-hlcdc MFD driver binding, but this shouldn't hurt, so

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
>  drivers/pwm/pwm-atmel-hlcdc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
> index 522f7075bb1a..fa5feaba25a5 100644
> --- a/drivers/pwm/pwm-atmel-hlcdc.c
> +++ b/drivers/pwm/pwm-atmel-hlcdc.c
> @@ -225,6 +225,10 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = {
>  		.compatible = "atmel,sama5d3-hlcdc",
>  		.data = &atmel_hlcdc_pwm_sama5d3_errata,
>  	},
> +	{
> +		.compatible = "atmel,sama5d4-hlcdc",
> +		.data = &atmel_hlcdc_pwm_sama5d3_errata,
> +	},
>  	{ /* sentinel */ },
>  };
>  



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pwm: atmel-hlcdc: add errata handling for sama5d4
  2015-02-20 16:06 ` Boris Brezillon
@ 2015-02-20 16:26   ` Nicolas Ferre
  2015-03-11 11:00     ` Thierry Reding
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Ferre @ 2015-02-20 16:26 UTC (permalink / raw)
  To: Boris Brezillon, thierry.reding
  Cc: linux-arm-kernel, linux-pwm, linux-kernel, Alexandre Belloni

Le 20/02/2015 17:06, Boris Brezillon a écrit :
> Hi Nicolas,
> 
> On Fri, 20 Feb 2015 16:58:18 +0100
> Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> 
>> sama5d4 SoC also has an errata on the HLCDC PWM. It is the same as the sama5d3
>> that is forbidding the use of div1 prescaler.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> 
> The "atmel,sama5d4-hlcdc" compatible string is not yet documented in
> the atmel-hlcdc MFD driver binding, but this shouldn't hurt, so

Yes, I'll document it when I'm submitting your patches that add the
compatibility strings to the drivers/mfd/atmel-hlcdc.c. (with
atmel,at91sam9x5-hlcdc as well).

> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Thanks, bye.

>> ---
>>  drivers/pwm/pwm-atmel-hlcdc.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
>> index 522f7075bb1a..fa5feaba25a5 100644
>> --- a/drivers/pwm/pwm-atmel-hlcdc.c
>> +++ b/drivers/pwm/pwm-atmel-hlcdc.c
>> @@ -225,6 +225,10 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = {
>>  		.compatible = "atmel,sama5d3-hlcdc",
>>  		.data = &atmel_hlcdc_pwm_sama5d3_errata,
>>  	},
>> +	{
>> +		.compatible = "atmel,sama5d4-hlcdc",
>> +		.data = &atmel_hlcdc_pwm_sama5d3_errata,
>> +	},
>>  	{ /* sentinel */ },
>>  };
>>  
> 
> 
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pwm: atmel-hlcdc: add errata handling for sama5d4
  2015-02-20 16:26   ` Nicolas Ferre
@ 2015-03-11 11:00     ` Thierry Reding
  0 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2015-03-11 11:00 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: Boris Brezillon, linux-arm-kernel, linux-pwm, linux-kernel,
	Alexandre Belloni

[-- Attachment #1: Type: text/plain, Size: 939 bytes --]

On Fri, Feb 20, 2015 at 05:26:34PM +0100, Nicolas Ferre wrote:
> Le 20/02/2015 17:06, Boris Brezillon a écrit :
> > Hi Nicolas,
> > 
> > On Fri, 20 Feb 2015 16:58:18 +0100
> > Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> > 
> >> sama5d4 SoC also has an errata on the HLCDC PWM. It is the same as the sama5d3
> >> that is forbidding the use of div1 prescaler.
> >>
> >> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> > 
> > The "atmel,sama5d4-hlcdc" compatible string is not yet documented in
> > the atmel-hlcdc MFD driver binding, but this shouldn't hurt, so
> 
> Yes, I'll document it when I'm submitting your patches that add the
> compatibility strings to the drivers/mfd/atmel-hlcdc.c. (with
> atmel,at91sam9x5-hlcdc as well).
> 
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

I'll take your word on it that this will be documented, so I've applied
this.

Thanks,
Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-03-11 11:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-20 15:58 [PATCH] pwm: atmel-hlcdc: add errata handling for sama5d4 Nicolas Ferre
2015-02-20 16:06 ` Boris Brezillon
2015-02-20 16:26   ` Nicolas Ferre
2015-03-11 11:00     ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).