From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753904AbbCKMt2 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 Mar 2015 08:49:28 -0400
Received: from pandora.arm.linux.org.uk ([78.32.30.218]:37702 "EHLO
	pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752816AbbCKMtZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 Mar 2015 08:49:25 -0400
Date: Wed, 11 Mar 2015 12:49:11 +0000
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Rob Herring <robherring2@gmail.com>
Cc: Murali Karicheri <m-karicheri2@ti.com>,
        Grant Likely <grant.likely@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>, Arnd Bergmann <arnd@arndb.de>,
        Suravee Suthikulanit <Suravee.Suthikulpanit@amd.com>,
        Will Deacon <will.deacon@arm.com>, Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH] pci: of : fix BUG: unable to handle kernel
Message-ID: <20150311124911.GA8656@n2100.arm.linux.org.uk>
References: <1426001139-18419-1-git-send-email-m-karicheri2@ti.com>
 <CAL_JsqJPvW5q4XwwenFTHrDG4cU5uTd7n-vLKj0mdV9FbVC4Ag@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAL_JsqJPvW5q4XwwenFTHrDG4cU5uTd7n-vLKj0mdV9FbVC4Ag@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 11, 2015 at 07:35:45AM -0500, Rob Herring wrote:
> On Tue, Mar 10, 2015 at 10:25 AM, Murali Karicheri <m-karicheri2@ti.com> wrote:
> > On some platforms such as that based on x86, ia64 etc, root bus is
> > created with parent node passed in as NULL to pci_create_root_bus().
> > On these platforms, the patch series "PCI: get DMA configuration from
> > parent device" when applied causes kernel crash. So add a check for this
> > in of_pci_dma_configure()
> 
> Wouldn't these arches have OF disabled and call an empty function?
> Regardless, we still need this.
> 
> > Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> 
> I'm assuming Bjorn will apply this.
> 
> Acked-by: Rob Herring <robh@kernel.org>

It might be an idea to read the subject line...

"fix BUG: unable to handle kernel"

which is meaningless.  It needs a much better subject line before it can
be committed.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.