From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753321AbbCKON1 (ORCPT ); Wed, 11 Mar 2015 10:13:27 -0400 Received: from ringil.hengli.com.au ([178.18.16.133]:60193 "EHLO ringil.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753266AbbCKONY (ORCPT ); Wed, 11 Mar 2015 10:13:24 -0400 Date: Thu, 12 Mar 2015 01:13:22 +1100 From: Herbert Xu To: Dmitry Torokhov Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: amcc: remove incorrect __init/__exit markups Message-ID: <20150311141322.GD5713@gondor.apana.org.au> References: <20150309203539.GA11240@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150309203539.GA11240@dtor-ws> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 01:35:39PM -0700, Dmitry Torokhov wrote: > Even if bus is not hot-pluggable, the devices can be bound and unbound > from the driver via sysfs, so we should not be using __init/__exit > annotations on probe() and remove() methods. The only exception is > drivers registered with platform_driver_probe() which specifically > disables sysfs bind/unbind attributes. > > Signed-off-by: Dmitry Torokhov Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt