From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753716AbbCKOYF (ORCPT ); Wed, 11 Mar 2015 10:24:05 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:40251 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752277AbbCKOYB (ORCPT ); Wed, 11 Mar 2015 10:24:01 -0400 Date: Wed, 11 Mar 2015 15:24:18 +0100 From: Christoffer Dall To: Paolo Bonzini Cc: Marc Zyngier , Eric Auger , "eric.auger@st.com" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , Andre Przywara , "linux-kernel@vger.kernel.org" , "patches@linaro.org" , "gleb@kernel.org" Subject: Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support Message-ID: <20150311142418.GB14799@cbox> References: <1425464076-20558-1-git-send-email-eric.auger@linaro.org> <1425464076-20558-6-git-send-email-eric.auger@linaro.org> <54F8359A.4020405@arm.com> <54F83DAE.2060607@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54F83DAE.2060607@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 05, 2015 at 12:27:42PM +0100, Paolo Bonzini wrote: > > > On 05/03/2015 11:53, Marc Zyngier wrote: > > > +#ifdef CONFIG_HAVE_KVM_IRQFD > > > + case KVM_CAP_IRQFD: > > > + r = vgic_present; > > > + break; > > > +#endif > > > > Nitpick: we have "select HAVE_KVM_IRQFD", so we can lose the #ifdef-ery. > > Alternatively, I've just posted a patch to move the KVM_CAP_IRQFD case > to common code. > > vgic_present probably should be replaced by > IS_ENABLED(CONFIG_KVM_ARM_VGIC). I've sent a patch for this. > I have applied all of this together with my kill-the-vgic-config-option patch here: git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git queue Take a look please. Thanks, -Christoffer