From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751730AbbCKO65 (ORCPT ); Wed, 11 Mar 2015 10:58:57 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33490 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750769AbbCKO6x (ORCPT ); Wed, 11 Mar 2015 10:58:53 -0400 Date: Wed, 11 Mar 2015 20:28:41 +0530 From: Sudip Mukherjee To: Lorenzo Stoakes Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/6] staging: sm750fb: Remove spinlock helper function Message-ID: <20150311145841.GA30040@sudip-PC> References: <1426070749-32024-1-git-send-email-lstoakes@gmail.com> <1426070749-32024-3-git-send-email-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426070749-32024-3-git-send-email-lstoakes@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2015 at 10:45:49AM +0000, Lorenzo Stoakes wrote: > This patch removes the unnecessary spinlock helper function and instead > calls spin_lock and spin_unlock directly. > > This does *not* resolve sparse warnings about context imbalances but these are > spurious. tested the whole series on hardware, looks ok. now it depends on Greg if he wants to accept patches with such big commit logs, and another problem he will face is to get some patches from this thread and some from the old thread. (while testing i faced this problem to maintain the sequence of patches) regards sudip