LKML Archive on
help / color / mirror / Atom feed
From: Richard Cochran <>
To: Stathis Voukelatos <>
Subject: Re: [PATCH net-next v4 0/3] Linn Ethernet Packet Sniffer driver
Date: Wed, 11 Mar 2015 16:03:48 +0100	[thread overview]
Message-ID: <20150311150348.GA11272@localhost.localdomain> (raw)
In-Reply-To: <>

On Wed, Mar 11, 2015 at 11:20:59AM +0000, Stathis Voukelatos wrote:
> Our feeling is that we will have to test and verify that a move to gPTP
> will fit with the use cases that we have to support and that will
> require a fair amount of effort and rewrite of application software.
> If the driver is not acceptable with the current interface we may need
> to maintain it as a private patch until we are ready to move to gPTP
> as you recommend.

Sure, there is nothing wrong with that.  For the kernel, we want to
build good interfaces for future applications.  Sometimes reworking
the applications that use the old, private interfaces is just too much
work, so you have to maintain those interfaces in your products.

> I was referring to the Songcast protocol we are using which is part
> of the OpenHome suite ( and runs on top of UDP.
> It could be filtered by testing the first 5 bytes of the payload.

Sounds promising.

> In our implementation we also add the destination IP and port to
> the filter to make it more reliable, but hwtstamp_rx_filters cannot
> accept parameters.

If the IP is a defined multicast group address, and if the port is
well a known port, then you should of course include them in the
driver level filter.

Adding a unicast destination IP doesn't make it more reliable, because
frames addressed to other hosts are switched away from the host (or
dropped by the MAC).

> However, I will test that and maybe come back with
> a patch to expand the hwtstamp_rx_filter enum initially?

It probably makes more sense to present the expanded filter list in
the same patch series with the new driver that uses it, in order to
see the context.  So I would hold off posting until both are ready.


      reply	other threads:[~2015-03-11 15:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 16:48 Stathis Voukelatos
2015-02-24 16:48 ` [PATCH net-next v4 1/3] Linn Ethernet packet sniffer: device tree binding and vendor prefix Stathis Voukelatos
2015-02-24 16:48 ` [PATCH net-next v4 2/3] Linn packet sniffer core framework Stathis Voukelatos
2015-02-24 16:48 ` [PATCH net-next v4 3/3] Linn Ethernet packet sniffer driver Stathis Voukelatos
2015-02-25 15:19 ` [PATCH net-next v4 0/3] Linn Ethernet Packet Sniffer driver Richard Cochran
2015-02-25 17:01   ` Richard Cochran
2015-02-25 17:12     ` Stathis Voukelatos
2015-02-25 17:30       ` Richard Cochran
2015-02-27 17:22         ` Stathis Voukelatos
     [not found]         ` <>
2015-02-27 18:14           ` Richard Cochran
2015-03-06 13:45             ` Stathis Voukelatos
2015-03-06 15:24               ` Richard Cochran
     [not found]             ` <>
2015-03-06 15:22               ` Richard Cochran
2015-03-11 11:20                 ` Stathis Voukelatos
2015-03-11 15:03                   ` Richard Cochran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150311150348.GA11272@localhost.localdomain \ \ \ \ \ \
    --subject='Re: [PATCH net-next v4 0/3] Linn Ethernet Packet Sniffer driver' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).