From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752668AbbCKTJB (ORCPT ); Wed, 11 Mar 2015 15:09:01 -0400 Received: from mail.us.es ([193.147.175.20]:40731 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbbCKTI5 (ORCPT ); Wed, 11 Mar 2015 15:08:57 -0400 X-Qmail-Scanner-Diagnostics: from 127.0.0.1 by antivirus6 (envelope-from , uid 501) with qmail-scanner-2.10 (clamdscan: 0.98.6/20179. spamassassin: 3.4.0. Clear:RC:1(127.0.0.1):SA:0(-103.2/7.5):. Processed in 1.885778 secs); 11 Mar 2015 19:08:54 -0000 X-Spam-ASN: AS12715 87.216.0.0/16 X-Envelope-From: pneira@us.es Date: Wed, 11 Mar 2015 20:12:40 +0100 From: Pablo Neira Ayuso To: Jozsef Kadlecsik Cc: kbuild test robot , kbuild-all@01.org, Patrick McHardy , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: ipset: fix boolreturn.cocci warnings Message-ID: <20150311191240.GA9577@salvia> References: <201502112043.OvntWCjd%fengguang.wu@intel.com> <20150211123305.GA32347@waimea> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jozsef, On Wed, Mar 11, 2015 at 08:08:26PM +0100, Jozsef Kadlecsik wrote: > On Wed, 11 Feb 2015, kbuild test robot wrote: > > > net/netfilter/xt_set.c:196:9-10: WARNING: return of 0/1 in function 'set_match_v3' with return type bool > > net/netfilter/xt_set.c:242:9-10: WARNING: return of 0/1 in function 'set_match_v4' with return type bool > > > > Return statements in functions returning bool should use > > true/false instead of 1/0. > > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > > > CC: Jozsef Kadlecsik > > Signed-off-by: Fengguang Wu > > Patch is applied, thanks. I took the liberty to pass this to David already. 7f73b9f netfilter: ipset: fix boolreturn.cocci warnings