From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753849AbbCLILK (ORCPT ); Thu, 12 Mar 2015 04:11:10 -0400 Received: from LGEMRELSE6Q.lge.com ([156.147.1.121]:45564 "EHLO lgemrelse6q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753823AbbCLIK7 (ORCPT ); Thu, 12 Mar 2015 04:10:59 -0400 X-Original-SENDERIP: 10.177.220.203 X-Original-MAILFROM: namhyung@kernel.org Date: Thu, 12 Mar 2015 17:05:19 +0900 From: Namhyung Kim To: He Kuang Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com, acme@kernel.org, jolsa@kernel.org, wangnan0@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 2/2] perf hists browser: Fix UI bug after zoom into thread/dso/symbol Message-ID: <20150312080519.GL943@sejong> References: <20150311002617.GG943@sejong> <1426077363-855-1-git-send-email-hekuang@huawei.com> <1426077363-855-2-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1426077363-855-2-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2015 at 08:36:03PM +0800, He Kuang wrote: > When zoom into thread/dso/symbol, the fold/unfold stat is cleared in > hists__filter_by_thread/dso/symbol(), but h->nr_rows is not cleared. So > if we toggle fold stat on the unfold entires, nr_entries got a wrong > value. > > This bug can be reproduced as follows: > > $ perf record -g -e syscalls:sys_enter_open ls > $ perf report > > Children Self Command Shared Object Symbol > ================================================================ > + 50.00% 0.00% ls ld64.so [.] _dl_get_ready_to_run > - 50.00% 0.00% ls ld64.so [.] _dl_load_shared_library > _dl_load_shared_library <= [Zoom into thread/dso] > _dl_get_ready_to_run > _start > ... > > In the new thread hists, all entries reset to fold, if we unfold the > same entry as we previously unfolded, nr_entries got wrong value, and we > can't move down cursor to bottom row. > > Thread: ls > Children Self Command Shared Object Symbol > ================================================================ > + 50.00% 0.00% ls ld64.so [.] _dl_get_ready_to_run > - 50.00% 0.00% ls ld64.so [.] _dl_load_shared_library > _dl_load_shared_library > _dl_get_ready_to_run <= [cursor may stop here, can't move down] > _start > ... > > This patch clear h->nr_rows to fix this bug. > > Signed-off-by: He Kuang Acked-by: Namhyung Kim Thanks, Namhyung > --- > tools/perf/util/hist.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c > index 70b48a6..24aff7d 100644 > --- a/tools/perf/util/hist.c > +++ b/tools/perf/util/hist.c > @@ -1169,6 +1169,7 @@ static void hists__remove_entry_filter(struct hists *hists, struct hist_entry *h > /* force fold unfiltered entry for simplicity */ > h->ms.unfolded = false; > h->row_offset = 0; > + h->nr_rows = 0; > > hists->stats.nr_non_filtered_samples += h->stat.nr_events; > > -- > 2.2.0.33.gc18b867 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/