From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755116AbbCMMI2 (ORCPT ); Fri, 13 Mar 2015 08:08:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35980 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752889AbbCMMI0 (ORCPT ); Fri, 13 Mar 2015 08:08:26 -0400 Date: Fri, 13 Mar 2015 13:08:17 +0100 From: Mateusz Guzik To: Alexander Viro , Serge Hallyn Cc: Paul Moore , Eric Paris , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH 0/2] avoid prepare_creds in faccessat when possible Message-ID: <20150313120816.GA2527@mguzik> References: <1425933347-6080-1-git-send-email-mguzik@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1425933347-6080-1-git-send-email-mguzik@redhat.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 09:35:45PM +0100, Mateusz Guzik wrote: > Sometimes faccessat needs to modify current thread's credentials, but > calls prepare_creds unconditionally. > > However, typically resulting credentials are identical to original ones > and in that case newcredentials are unnecessary. We can detect this before > allocating anything. > > This patch series adds a helper which allows comparing capability sets and > modifies faccessat to use it. > > Mateusz Guzik (2): > CAPABILITIES: add cap_isequal helper > fs: avoid unnecessary prepare_creds in faccessat > Can I get some (N)ACKs on this one? Thanks, -- Mateusz Guzik