LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dave Jones <davej@codemonkey.org.uk>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
	linux-kernel@vger.kernel.org, mmarek@suse.cz,
	linux-api@vger.kernel.org
Subject: Re: [PATCH v4 4/9] selftests: Add install target
Date: Fri, 13 Mar 2015 12:33:12 -0400	[thread overview]
Message-ID: <20150313163312.GA24666@codemonkey.org.uk> (raw)
In-Reply-To: <1426130144.25936.4.camel@ellerman.id.au>

On Thu, Mar 12, 2015 at 02:15:44PM +1100, Michael Ellerman wrote:
 > On Wed, 2015-03-11 at 07:18 -0600, Shuah Khan wrote:
 > > On 03/10/2015 10:06 PM, Michael Ellerman wrote:
 > > > This adds make install support to selftests. The basic usage is:
 > > > 
 > > > v3: Rebase onto 4.0-rc2.
 > > >     Rename all.sh to run_kselftest.sh.
 > > >     Add --no-print-directory to emit_tests invocation.
 > > > v4: Rebase onto 4.0-rc3, add TEST_FILES to efivars and vm tests, remove
 > > >     newlines from echoes.
 > > 
 > > I don't see my comments addressed. If you want me to take
 > > this work, please address the following comments:
 > > 
 > > - Name install directory kselftest. It should work with the
 > >   the use-case.
 > > 
 > >   make INSTALL_PATH=/tmp make install
 > >   The install directory should be /tmp/kselftest
 > > 
 > > - Flatten the directory with all tests under /tmp/kselftest
 > > 
 > > I am wasting lot of time because you don't fully address my
 > > comments and send patches that dont' work correctly. Please
 > > make sure your patches don't generate work for me.
 > 
 > You're wasting a lot of time? You have got to be kidding me. You are wasting a
 > lot of *my* time.
 > 
 > You have my patches, they're signed off, you can do what you wish with them.
 > Good luck.

This is getting silly. We've spent three months arguing over shell
scripts and makefiles for what should be a trivial feature.
We make fundamental changes to the VM code with less contention.

It's not helped that timezones are working against everyone here,
so even minor changes end up taking a while to get reposted, re-reviewed
etc, but the level of pushback because something isn't perfect is absurd,
especially when we're talking about new features.

If you want the in-kernel variant to be perfect every step of the way,
and move slowly and never introduce subtle breakage along the way that then
gets fixed up in subsequent changes, maybe a faster moving external project
that syncs up with the kernel tree is the way forward.

If kselftests is going to evolve into something useful, something has to change.

	Dave


  reply	other threads:[~2015-03-13 16:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11  4:05 [PATCH v4 1/9] kbuild: Don't pass -rR to selftest makefiles Michael Ellerman
2015-03-11  4:05 ` [PATCH v4 2/9] kbuild: Don't pass LDFLAGS to selftest Makefile Michael Ellerman
2015-03-11 16:08   ` Shuah Khan
2015-03-13 18:06   ` Shuah Khan
2015-03-11  4:05 ` [PATCH v4 3/9] selftests: Introduce minimal shared logic for running tests Michael Ellerman
2015-03-13 17:19   ` Shuah Khan
2015-03-13 20:28     ` Shuah Khan
2015-03-11  4:06 ` [PATCH v4 4/9] selftests: Add install target Michael Ellerman
2015-03-11 13:18   ` Shuah Khan
2015-03-11 16:03     ` Shuah Khan
2015-03-12  3:11       ` Michael Ellerman
2015-03-12  3:15     ` Michael Ellerman
2015-03-13 16:33       ` Dave Jones [this message]
2015-03-13 17:08         ` Shuah Khan
2015-03-13 17:20   ` Shuah Khan
2015-03-13 21:32     ` Shuah Khan
2015-03-13 23:08       ` Shuah Khan
2015-03-16  3:04       ` Michael Ellerman
2015-03-16  3:12         ` Michael Ellerman
2015-03-18 14:30         ` Shuah Khan
2015-03-11  4:06 ` [PATCH v4 5/9] selftests: Add install support for the powerpc tests Michael Ellerman
2015-03-11  4:06 ` [PATCH v4 6/9] selftests: Set CC using CROSS_COMPILE once in lib.mk Michael Ellerman
2015-03-11  4:06 ` [PATCH v4 7/9] selftests/timers: Use implicit rules Michael Ellerman
2015-03-11  4:06 ` [PATCH v4 8/9] selftests/mqueue: " Michael Ellerman
2015-03-11  4:06 ` [PATCH v4 9/9] selftests/mount: " Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150313163312.GA24666@codemonkey.org.uk \
    --to=davej@codemonkey.org.uk \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=mpe@ellerman.id.au \
    --cc=shuahkh@osg.samsung.com \
    --subject='Re: [PATCH v4 4/9] selftests: Add install target' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).