LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.cz>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
david@fromorbit.com, mgorman@suse.de, riel@redhat.com,
fengguang.wu@intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: Allow small allocations to fail
Date: Sun, 15 Mar 2015 13:13:17 +0100 [thread overview]
Message-ID: <20150315121317.GA30685@dhcp22.suse.cz> (raw)
In-Reply-To: <201503151443.CFE04129.MVFOOStLFHFOQJ@I-love.SAKURA.ne.jp>
On Sun 15-03-15 14:43:37, Tetsuo Handa wrote:
[...]
> If you want to count only those retries which involved OOM killer, you need
> to do like
>
> - nr_retries++;
> + if (gfp_mask & __GFP_FS)
> + nr_retries++;
>
> in this patch.
No, we shouldn't create another type of hidden NOFAIL allocation like
this. I understand that the wording of the changelog might be confusing,
though.
It says: "This implementation counts only those retries which involved
OOM killer because we do not want to be too eager to fail the request."
Would it be more clear if I changed that to?
"This implemetnation counts only those retries when the system is
considered OOM because all previous reclaim attempts have resulted
in no progress because we do not want to be too eager to fail the
request."
We definitely _want_ to fail GFP_NOFS allocations.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2015-03-15 12:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 20:54 [PATCH 0/2] Move away from non-failing small allocations Michal Hocko
2015-03-11 20:54 ` [PATCH 1/2] mm: Allow small allocations to fail Michal Hocko
2015-03-12 12:54 ` Tetsuo Handa
2015-03-12 13:12 ` Michal Hocko
2015-03-15 5:43 ` Tetsuo Handa
2015-03-15 12:13 ` Michal Hocko [this message]
2015-03-15 13:06 ` Tetsuo Handa
2015-03-16 7:46 ` [PATCH 1/2 v2] " Michal Hocko
2015-03-16 21:11 ` Johannes Weiner
2015-03-17 10:25 ` Michal Hocko
2015-03-17 13:29 ` Johannes Weiner
2015-03-17 14:17 ` Michal Hocko
2015-03-17 17:26 ` Johannes Weiner
2015-03-17 19:41 ` Michal Hocko
2015-03-18 9:10 ` Vlastimil Babka
2015-03-18 12:04 ` Michal Hocko
2015-03-18 12:36 ` Tetsuo Handa
2015-03-18 11:35 ` Tetsuo Handa
2015-03-17 11:13 ` Tetsuo Handa
2015-03-17 13:15 ` Michal Hocko
2015-03-18 11:33 ` Tetsuo Handa
2015-03-18 12:23 ` Michal Hocko
2015-03-19 11:03 ` Tetsuo Handa
2015-03-11 20:54 ` [PATCH 2/2] mmotm: Enable small allocation " Michal Hocko
2015-03-11 22:36 ` [PATCH 0/2] Move away from non-failing small allocations Sasha Levin
2015-03-16 22:38 ` Andrew Morton
2015-03-17 9:07 ` Michal Hocko
2015-03-17 14:06 ` Tetsuo Handa
2015-04-02 11:53 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150315121317.GA30685@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).