LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 1/1 linux-next] udf: use int for allocated blocks instead of sector_t
Date: Mon, 16 Mar 2015 08:24:33 +0100	[thread overview]
Message-ID: <20150316072433.GA4934@quack.suse.cz> (raw)
In-Reply-To: <1426413263-3466-1-git-send-email-fabf@skynet.be>

On Sun 15-03-15 10:54:23, Fabian Frederick wrote:
> Fix the following warnings:
> 
> fs/udf/balloc.c:768:15: warning: conversion to 'sector_t' from 'int'
> may change the sign of the result [-Wsign-conversion]
>    allocated = udf_bitmap_prealloc_blocks(sb,
>                ^
> fs/udf/balloc.c:773:15: warning: conversion to 'sector_t' from 'int'
> may change the sign of the result [-Wsign-conversion]
>    allocated = udf_table_prealloc_blocks(sb,
>                ^
> fs/udf/balloc.c:778:15: warning: conversion to 'sector_t' from 'int'
> may change the sign of the result [-Wsign-conversion]
>    allocated = udf_bitmap_prealloc_blocks(sb,
>                ^
> fs/udf/balloc.c:783:15: warning: conversion to 'sector_t' from 'int'
> may change the sign of the result [-Wsign-conversion]
>    allocated = udf_table_prealloc_blocks(sb,
>                ^
> fs/udf/balloc.c:791:26: warning: conversion to 'loff_t' from 'sector_t'
> may change the sign of the result [-Wsign-conversion]
>    inode_add_bytes(inode, allocated << sb->s_blocksize_bits);
>                           ^
> fs/udf/balloc.c:792:2: warning: conversion to 'int' from 'sector_t'
> may alter its value [-Wconversion]
>   return allocated;
> 
> Suggested-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
  Thanks. Applied to my tree.

								Honza

> ---
>  fs/udf/balloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c
> index 1ba2baa..75d5f421 100644
> --- a/fs/udf/balloc.c
> +++ b/fs/udf/balloc.c
> @@ -762,7 +762,7 @@ inline int udf_prealloc_blocks(struct super_block *sb,
>  			       uint32_t block_count)
>  {
>  	struct udf_part_map *map = &UDF_SB(sb)->s_partmaps[partition];
> -	sector_t allocated;
> +	int allocated;
>  
>  	if (map->s_partition_flags & UDF_PART_FLAG_UNALLOC_BITMAP)
>  		allocated = udf_bitmap_prealloc_blocks(sb,
> -- 
> 1.9.1
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

      reply	other threads:[~2015-03-16  7:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-15  9:54 Fabian Frederick
2015-03-16  7:24 ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150316072433.GA4934@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=fabf@skynet.be \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/1 linux-next] udf: use int for allocated blocks instead of sector_t' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).