LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sylvain Rochet <sylvain.rochet@finsecur.com>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: nicolas.ferre@atmel.com, linux@arm.linux.org.uk,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	alexandre.belloni@free-electrons.com, peda@axentia.se,
	sergei.shtylyov@cogentembedded.com, linux@maxim.org.za
Subject: Re: [PATCH v2.0 1/2] pm: at91: add the PM initialization for the sama5d3 and sama5d4
Date: Mon, 16 Mar 2015 11:21:12 +0100	[thread overview]
Message-ID: <20150316102112.GA29170@gradator.net> (raw)
In-Reply-To: <1425873428-8292-1-git-send-email-wenyou.yang@atmel.com>

Hello Wenyou,

On Mon, Mar 09, 2015 at 11:57:08AM +0800, Wenyou Yang wrote:
> To get the mpddrc peripheral id from the PM initialization,
> which will be used to disable mpddrc'c clock during suspending.

> +void __init sam5d3_pm_init(void)
> +{
> +	at91_dt_ramc();
> +	at91_pm_data.uhp_udp_mask = AT91SAM926x_PMC_UHP | AT91SAM926x_PMC_UDP;
> +	at91_pm_data.memctrl = AT91_MEMCTRL_DDRSDR;
> +	at91_pm_data.ddrc_pid = SAMA5D3_ID_MPDDRC;
> +	return at91_pm_init();
> +}
> +
> +void __init sam5d4_pm_init(void)
> +{
> +	at91_dt_ramc();
> +	at91_pm_data.uhp_udp_mask = AT91SAM926x_PMC_UHP | AT91SAM926x_PMC_UDP;
> +	at91_pm_data.memctrl = AT91_MEMCTRL_DDRSDR;
> +	at91_pm_data.ddrc_pid = SAMA5D4_ID_MPDDRC;
> +	at91_pm_data.is_sama5d4 = true;
> +	return at91_pm_init();
> +}

> +static void __init sama5d4_dt_device_init(void)
> +{
> +	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> +	sam5d4_pm_init();
> +}

This doesn't look right, where is sam5d3_pm_init() actually used ?

Sylvain

  reply	other threads:[~2015-03-16 10:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09  3:56 [PATCH v2.0 0/2] ARM: AT91: pm: add support to disable the DDR's clock Wenyou Yang
2015-03-09  3:57 ` [PATCH v2.0 1/2] pm: at91: add the PM initialization for the sama5d3 and sama5d4 Wenyou Yang
2015-03-16 10:21   ` Sylvain Rochet [this message]
2015-03-18  0:52     ` Yang, Wenyou
2015-03-09  3:57 ` [PATCH v2.0 2/2] pm: at91: add support to disable/enable the DDR clock Wenyou Yang
2015-03-12 18:59 ` [PATCH v2.0 0/2] ARM: AT91: pm: add support to disable the DDR's clock Sylvain Rochet
2015-03-13 13:43 ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150316102112.GA29170@gradator.net \
    --to=sylvain.rochet@finsecur.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linux@maxim.org.za \
    --cc=nicolas.ferre@atmel.com \
    --cc=peda@axentia.se \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=wenyou.yang@atmel.com \
    --subject='Re: [PATCH v2.0 1/2] pm: at91: add the PM initialization for the sama5d3 and sama5d4' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).