Re: [PATCH] reiserfs: fix __RASSERT format string

[Jan Kara <jack@suse.cz>]

On Tue 17-03-15 10:26:44, Jeff Mahoney wrote:
> On 3/16/15 9:45 AM, Nicolas Iooss wrote:
> > __RASSERT format string does not use the PID argument.
> > reiserfs_panic arguments are therefore formatted with the wrong
> > format specifier (for example __LINE__ with %s).  This bug was
> > introduced when commit c3a9c2109f84 ("reiserfs: rework
> > reiserfs_panic") removed a "reiserfs[%i]" prefix.
> > 
> > This bug is only triggered when using CONFIG_REISERFS_CHECK,
> > otherwise __RASSERT is never used.
> > 
> > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> Acked-by: Jeff Mahoney <jeffm@suse.com>
  Thanks. I've added the patch to my tree.

							Honza

> 
> > Fixes: c3a9c2109f84 ("reiserfs: rework reiserfs_panic") --- 
> > fs/reiserfs/reiserfs.h | 1 - 1 file changed, 1 deletion(-)
> > 
> > diff --git a/fs/reiserfs/reiserfs.h b/fs/reiserfs/reiserfs.h index
> > bb79cddf0a1f..2adcde137c3f 100644 --- a/fs/reiserfs/reiserfs.h +++
> > b/fs/reiserfs/reiserfs.h @@ -910,7 +910,6 @@ do {									\ if
> > (!(cond))							\ reiserfs_panic(NULL, "assertion failure", "("
> > #cond ") at " \ __FILE__ ":%i:%s: " format "\n",		\ -
> > in_interrupt() ? -1 : task_pid_nr(current), \ __LINE__, __func__ ,
> > ##args);		\ } while (0)
> > 
> > 
> 
> 
> -- 
> Jeff Mahoney
> SUSE Labs
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR