LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Jeff Mahoney <jeffm@suse.com>
Cc: Nicolas Iooss <nicolas.iooss_linux@m4x.org>,
	reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] reiserfs: fix __RASSERT format string
Date: Tue, 17 Mar 2015 16:22:44 +0100	[thread overview]
Message-ID: <20150317152244.GA6670@quack.suse.cz> (raw)
In-Reply-To: <550839A4.9070608@suse.com>

On Tue 17-03-15 10:26:44, Jeff Mahoney wrote:
> On 3/16/15 9:45 AM, Nicolas Iooss wrote:
> > __RASSERT format string does not use the PID argument.
> > reiserfs_panic arguments are therefore formatted with the wrong
> > format specifier (for example __LINE__ with %s).  This bug was
> > introduced when commit c3a9c2109f84 ("reiserfs: rework
> > reiserfs_panic") removed a "reiserfs[%i]" prefix.
> > 
> > This bug is only triggered when using CONFIG_REISERFS_CHECK,
> > otherwise __RASSERT is never used.
> > 
> > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> Acked-by: Jeff Mahoney <jeffm@suse.com>
  Thanks. I've added the patch to my tree.

							Honza

> 
> > Fixes: c3a9c2109f84 ("reiserfs: rework reiserfs_panic") --- 
> > fs/reiserfs/reiserfs.h | 1 - 1 file changed, 1 deletion(-)
> > 
> > diff --git a/fs/reiserfs/reiserfs.h b/fs/reiserfs/reiserfs.h index
> > bb79cddf0a1f..2adcde137c3f 100644 --- a/fs/reiserfs/reiserfs.h +++
> > b/fs/reiserfs/reiserfs.h @@ -910,7 +910,6 @@ do {									\ if
> > (!(cond))							\ reiserfs_panic(NULL, "assertion failure", "("
> > #cond ") at " \ __FILE__ ":%i:%s: " format "\n",		\ -
> > in_interrupt() ? -1 : task_pid_nr(current), \ __LINE__, __func__ ,
> > ##args);		\ } while (0)
> > 
> > 
> 
> 
> -- 
> Jeff Mahoney
> SUSE Labs
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

      reply	other threads:[~2015-03-17 15:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 12:55 reiserfs: inconsistent format in __RASSERT Nicolas Iooss
2015-03-16 13:05 ` Jeff Mahoney
2015-03-16 13:18   ` Nicolas Iooss
2015-03-16 13:45     ` [PATCH] reiserfs: fix __RASSERT format string Nicolas Iooss
2015-03-17 14:26       ` Jeff Mahoney
2015-03-17 15:22         ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150317152244.GA6670@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=jeffm@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.iooss_linux@m4x.org \
    --cc=reiserfs-devel@vger.kernel.org \
    --subject='Re: [PATCH] reiserfs: fix __RASSERT format string' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).