From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755936AbbCRHeg (ORCPT ); Wed, 18 Mar 2015 03:34:36 -0400 Received: from mail-we0-f179.google.com ([74.125.82.179]:34840 "EHLO mail-we0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755060AbbCRHed (ORCPT ); Wed, 18 Mar 2015 03:34:33 -0400 Date: Wed, 18 Mar 2015 08:41:14 +0100 From: Zahari Doychev To: ming.lei@canonical.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: zahari.doychev@linux.com Subject: Re: [PATCH v2] drivers: base: fw: fix ret value when loading fw Message-ID: <20150318074113.GM11294@riot.fritz.box> References: <1425980740-18919-1-git-send-email-zahari.doychev@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425980740-18919-1-git-send-email-zahari.doychev@linux.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 10:45:40AM +0100, Zahari Doychev wrote: > When using the user mode helper to load firmwares the function _request_firmware > gets a positive return value from fw_load_from_user_helper and because of this > the firmware buffer is not assigned. This happens only when the return value > is zero. This patch fixes this problem in _request_firmware_load. When the > completion is ready the return value is set to zero. > > Signed-off-by: Zahari Doychev > --- > > Changes from v1: > - move handling of wait_for_completion_interruptible_timeout() return value > Hi, what is the status of the patch? Is there something wrong with it? Regards, Zahari