From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756039AbbCRNmh (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Mar 2015 09:42:37 -0400
Received: from cantor2.suse.de ([195.135.220.15]:56407 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755960AbbCRNme (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Mar 2015 09:42:34 -0400
Date: Wed, 18 Mar 2015 14:42:32 +0100
From: David Sterba <dsterba@suse.cz>
To: Omar Sandoval <osandov@osandov.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v3 1/5] new helper: iov_iter_rw()
Message-ID: <20150318134232.GZ20767@suse.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Omar Sandoval <osandov@osandov.com>,
	Al Viro <viro@ZenIV.linux.org.uk>, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
References: <20150317181910.GK29656@ZenIV.linux.org.uk>
 <d80b0e1347c7df986754cedbf35abbc441affc59.1426626029.git.osandov@osandov.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d80b0e1347c7df986754cedbf35abbc441affc59.1426626029.git.osandov@osandov.com>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 17, 2015 at 02:04:02PM -0700, Omar Sandoval wrote:
>  /*
> + * Get one of READ or WRITE out of iter->type without any other flags OR'd in
> + * with it.
> + *
> + * The ?: is just for type safety.
> + */
> +#define iov_iter_rw(i) ((0 ? (struct iov_iter *)0 : (i))->type & RW_MASK)

I'm fine with that, thanks.