From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753345AbbCSLha (ORCPT ); Thu, 19 Mar 2015 07:37:30 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59111 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751386AbbCSLh1 (ORCPT ); Thu, 19 Mar 2015 07:37:27 -0400 Date: Thu, 19 Mar 2015 11:36:46 +0000 From: Mark Brown To: Ulf Hansson Cc: Doug Anderson , Heiko Stuebner , Jaehoon Chung , Seungwon Jeon , Alexandru Stan , Alim Akhtar , Sonny Rao , Andrew Bresticker , Addy Ke , Javier Martinez Canillas , "open list:ARM/Rockchip SoC..." , "linux-arm-kernel@lists.infradead.org" , Chris Ball , Johan Rudholm , Adrian Hunter , Tim Kryger , Andrew Gabbasov , Sascha Hauer , linux-mmc , "linux-kernel@vger.kernel.org" Message-ID: <20150319113646.GQ2869@sirena.org.uk> References: <1426112117-18220-1-git-send-email-dianders@chromium.org> <1426112117-18220-2-git-send-email-dianders@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+hz2tM55CCA8Ej21" Content-Disposition: inline In-Reply-To: X-Cookie: Wanna buy a duck? User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v4 2/4] mmc: core: Add mmc_regulator_set_vqmmc() X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --+hz2tM55CCA8Ej21 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 19, 2015 at 12:14:11PM +0100, Ulf Hansson wrote: > Agree. Moreover we need that API to also pick the closest value to > target, when trying the range "target->minimum". I also believe it The implementation *should* do that anyway, it's just not trivial to implement in an efficient fashion with the current information we have =66rom drivers. > would be good to allow both upper and lower limits to be zero. The lower limit can be zero already though it isn't clear to me that this is useful. Setting an upper limit of zero seems nonsensical, an upper limit that is lower than the lower limit isn't terribly obvious and removing the upper limit isn't safe - it means that we'll happily oversupply things which is a road to physical damage. --+hz2tM55CCA8Ej21 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVCrTNAAoJECTWi3JdVIfQt3sH/2eaSSvoyZOHqeqD0EBGzVsK AnlyVjHBrgJSmTNb1QCs1Luy4WV5ACtVWz8FytizSkfjmaaYwMHiR17S7meDYlxi SwRhRqW5PvSGHtahAF7vAk8W2ix2ZsSyhJmo1ZntTXUszPmgvgSvW3GWHZ4L1KPz hKhkPxSw1gIuukQ818GZq9CwSR3DBtluvfuTp7OXZTzmEM2XSxPtqfT+k3xNjs/Y z7J4dJtbacmfuxOzQv2HQTZwmzWkW9FAwKc7XnDrPK4Wi/nMXttMxDo8SdNOpN6E nJ8eunD9nXnufl8qGGHmFCF4XaqoRHt0+9s1EB5XpjHu00QbYdlIn+58deSfDZo= =hQFZ -----END PGP SIGNATURE----- --+hz2tM55CCA8Ej21--