From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754271AbbCaDOk (ORCPT ); Mon, 30 Mar 2015 23:14:40 -0400 Received: from mail-by2on0102.outbound.protection.outlook.com ([207.46.100.102]:28352 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754000AbbCaDOj (ORCPT ); Mon, 30 Mar 2015 23:14:39 -0400 Date: Mon, 30 Mar 2015 22:14:30 -0500 From: Scott Wood To: LEROY Christophe CC: Benjamin Herrenschmidt , Paul Mackerras , , Subject: Re: [v2,2/2] powerpc32: add support for csum_add() Message-ID: <20150331031430.GA7982@home.buserror.net> References: <20150203113927.8604D1A5F14@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150203113927.8604D1A5F14@localhost.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [2601:2:5800:3f7:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BLUPR07CA065.namprd07.prod.outlook.com (25.160.24.20) To BLUPR03MB1475.namprd03.prod.outlook.com (25.163.81.17) Authentication-Results: c-s.fr; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1475;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB391; X-Forefront-Antispam-Report: BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(51704005)(24454002)(42186005)(53416004)(77156002)(40100003)(110136001)(50986999)(19580405001)(87976001)(122386002)(92566002)(54356999)(76176999)(50466002)(33656002)(86362001)(97756001)(62966003)(46406003)(23726002)(46102003)(2950100001)(47776003)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR03MB1475;H:home.buserror.net;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:BLUPR03MB1475;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1475; X-Forefront-PRVS: 0532BF6DC2 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2015 03:14:36.1100 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1475 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 03, 2015 at 12:39:27PM +0100, LEROY Christophe wrote: > The C version of csum_add() as defined in include/net/checksum.h gives the > following assembly: > 0: 7c 04 1a 14 add r0,r4,r3 > 4: 7c 64 00 10 subfc r3,r4,r0 > 8: 7c 63 19 10 subfe r3,r3,r3 > c: 7c 63 00 50 subf r3,r3,r0 > > include/net/checksum.h also offers the possibility to define an arch specific > function. > This patch provides a ppc32 specific csum_add() inline function. > > Signed-off-by: Christophe Leroy > --- > v2: changed constraints on the __asm__ > > arch/powerpc/include/asm/checksum.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/powerpc/include/asm/checksum.h b/arch/powerpc/include/asm/checksum.h > index cfe806a..1e48cc7 100644 > --- a/arch/powerpc/include/asm/checksum.h > +++ b/arch/powerpc/include/asm/checksum.h > @@ -141,6 +141,18 @@ static inline __sum16 csum_tcpudp_magic(__be32 saddr, __be32 daddr, > { > return csum_fold(csum_tcpudp_nofold(saddr, daddr, len, proto, sum)); > } > + > +#define HAVE_ARCH_CSUM_ADD > +static inline __wsum csum_add(__wsum csum, __wsum addend) > +{ > + __asm__("\n\ s/__asm__/asm/ Use tabs to indent > + addc %0,%0,%1 \n\ > + addze %0,%0 \n\ Use ; to separate asm statements instead of using \n Use string concatenation instead of \ -Scott