LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Re: [PATCH v0 1/2] mfd/axp20x: add support for extcon cell
  2015-03-31 16:03 [PATCH v0 1/2] mfd/axp20x: add support for extcon cell Ramakrishna Pallala
@ 2015-03-31  8:50 ` Lee Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2015-03-31  8:50 UTC (permalink / raw)
  To: Ramakrishna Pallala
  Cc: linux-kernel, MyungJoo Ham, Chanwoo Choi, Samuel Ortiz,
	Carlo Caione, Jacob Pan

There is no such thing as v0, yhe first version should be v1.

You don't need to write v1 in the subject line either.

On Tue, 31 Mar 2015, Ramakrishna Pallala wrote:
> This patch adds the mfd cell info for axp288 extcon device.
> 
> Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
> ---
>  drivers/mfd/axp20x.c       |   28 ++++++++++++++++++++++++++++
>  include/linux/mfd/axp20x.h |    5 +++++
>  2 files changed, 33 insertions(+)
> 
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 0acbe52..30af1a3 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -290,6 +290,29 @@ static struct resource axp288_adc_resources[] = {
>  	},
>  };
>  
> +static struct resource axp288_extcon_resources[] = {
> +	{
> +		.start = AXP288_IRQ_VBUS_FALL,
> +		.end   = AXP288_IRQ_VBUS_FALL,
> +		.flags = IORESOURCE_IRQ,
> +	},
> +	{
> +		.start = AXP288_IRQ_VBUS_RISE,
> +		.end   = AXP288_IRQ_VBUS_RISE,
> +		.flags = IORESOURCE_IRQ,
> +	},
> +	{
> +		.start = AXP288_IRQ_MV_CHNG,
> +		.end   = AXP288_IRQ_MV_CHNG,
> +		.flags = IORESOURCE_IRQ,
> +	},
> +	{
> +		.start = AXP288_IRQ_BC_USB_CHNG,
> +		.end   = AXP288_IRQ_BC_USB_CHNG,
> +		.flags = IORESOURCE_IRQ,
> +	},
> +};
> +
>  static struct resource axp288_charger_resources[] = {
>  	{
>  		.start = AXP288_IRQ_OV,
> @@ -345,6 +368,11 @@ static struct mfd_cell axp288_cells[] = {
>  		.resources = axp288_adc_resources,
>  	},
>  	{
> +		.name = "extcon-axp288",
> +		.num_resources = ARRAY_SIZE(axp288_extcon_resources),
> +		.resources = axp288_extcon_resources,
> +	},
> +	{
>  		.name = "axp288_charger",
>  		.num_resources = ARRAY_SIZE(axp288_charger_resources),
>  		.resources = axp288_charger_resources,
> diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
> index dfabd6d..4ed8071 100644
> --- a/include/linux/mfd/axp20x.h
> +++ b/include/linux/mfd/axp20x.h
> @@ -275,4 +275,9 @@ struct axp20x_fg_pdata {
>  	int thermistor_curve[MAX_THERM_CURVE_SIZE][2];
>  };
>  
> +struct axp288_extcon_pdata {
> +	/* GPIO pin control to switch D+/D- lines b/w PMIC and SOC */
> +	struct gpio_desc *gpio_mux_cntl;
> +};
> +

What does this have to do with this patch?

>  #endif /* __LINUX_MFD_AXP20X_H */

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH v0 1/2] mfd/axp20x: add support for extcon cell
@ 2015-03-31 16:03 Ramakrishna Pallala
  2015-03-31  8:50 ` Lee Jones
  0 siblings, 1 reply; 2+ messages in thread
From: Ramakrishna Pallala @ 2015-03-31 16:03 UTC (permalink / raw)
  To: linux-kernel, MyungJoo Ham, Chanwoo Choi, Samuel Ortiz, Lee Jones
  Cc: Carlo Caione, Jacob Pan, Pallala Ramakrishna

This patch adds the mfd cell info for axp288 extcon device.

Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
---
 drivers/mfd/axp20x.c       |   28 ++++++++++++++++++++++++++++
 include/linux/mfd/axp20x.h |    5 +++++
 2 files changed, 33 insertions(+)

diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index 0acbe52..30af1a3 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -290,6 +290,29 @@ static struct resource axp288_adc_resources[] = {
 	},
 };
 
+static struct resource axp288_extcon_resources[] = {
+	{
+		.start = AXP288_IRQ_VBUS_FALL,
+		.end   = AXP288_IRQ_VBUS_FALL,
+		.flags = IORESOURCE_IRQ,
+	},
+	{
+		.start = AXP288_IRQ_VBUS_RISE,
+		.end   = AXP288_IRQ_VBUS_RISE,
+		.flags = IORESOURCE_IRQ,
+	},
+	{
+		.start = AXP288_IRQ_MV_CHNG,
+		.end   = AXP288_IRQ_MV_CHNG,
+		.flags = IORESOURCE_IRQ,
+	},
+	{
+		.start = AXP288_IRQ_BC_USB_CHNG,
+		.end   = AXP288_IRQ_BC_USB_CHNG,
+		.flags = IORESOURCE_IRQ,
+	},
+};
+
 static struct resource axp288_charger_resources[] = {
 	{
 		.start = AXP288_IRQ_OV,
@@ -345,6 +368,11 @@ static struct mfd_cell axp288_cells[] = {
 		.resources = axp288_adc_resources,
 	},
 	{
+		.name = "extcon-axp288",
+		.num_resources = ARRAY_SIZE(axp288_extcon_resources),
+		.resources = axp288_extcon_resources,
+	},
+	{
 		.name = "axp288_charger",
 		.num_resources = ARRAY_SIZE(axp288_charger_resources),
 		.resources = axp288_charger_resources,
diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
index dfabd6d..4ed8071 100644
--- a/include/linux/mfd/axp20x.h
+++ b/include/linux/mfd/axp20x.h
@@ -275,4 +275,9 @@ struct axp20x_fg_pdata {
 	int thermistor_curve[MAX_THERM_CURVE_SIZE][2];
 };
 
+struct axp288_extcon_pdata {
+	/* GPIO pin control to switch D+/D- lines b/w PMIC and SOC */
+	struct gpio_desc *gpio_mux_cntl;
+};
+
 #endif /* __LINUX_MFD_AXP20X_H */
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-31  8:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-31 16:03 [PATCH v0 1/2] mfd/axp20x: add support for extcon cell Ramakrishna Pallala
2015-03-31  8:50 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).