LKML Archive on
help / color / mirror / Atom feed
From: Ralf Baechle <>
To: Mark Brown <>
Cc: Bert Vermeulen <>,,,,
Subject: Re: [PATCH v2 0/1] spi: Add driver for Routerboard RB4xx boards
Date: Tue, 31 Mar 2015 16:22:47 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Mar 31, 2015 at 09:44:25AM +0100, Mark Brown wrote:

> On Mon, Mar 30, 2015 at 08:24:16PM +0200, Bert Vermeulen wrote:
> > Changes in v2:
> > This is a near complete rewrite of the original OpenWrt driver. All comments
> > were taken into account, and the spi_transfer.fast_write flag is gone.
> > Instead, the cs_change flag is used. It's not too bad a hack, as it really
> > does use CS.
> Don't send cover letters for single patches, if there's anything that
> needs saying it should either be in the changelog or after the ---.  A
> separate cover letter adds to the mail volume and probably means that
> the patch itself is inadequately described.

My personal grief with cover letters is that patchwork only collects
patches but cover letters themselves aren't patches.  Which means working
through patchwork I might miss important information.  Maybe I should
request an enhancement to patchwork.


      reply	other threads:[~2015-03-31 14:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 18:24 Bert Vermeulen
2015-03-30 18:24 ` [PATCH v2 1/1] spi: Add SPI driver for Mikrotik RB4xx series boards Bert Vermeulen
2015-03-30 19:14   ` Andy Shevchenko
2015-03-31  8:44 ` [PATCH v2 0/1] spi: Add driver for Routerboard RB4xx boards Mark Brown
2015-03-31 14:22   ` Ralf Baechle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2 0/1] spi: Add driver for Routerboard RB4xx boards' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).