From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754634AbbCaO1p (ORCPT ); Tue, 31 Mar 2015 10:27:45 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:58755 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753386AbbCaO1l (ORCPT ); Tue, 31 Mar 2015 10:27:41 -0400 Date: Tue, 31 Mar 2015 16:22:47 +0200 From: Ralf Baechle To: Mark Brown Cc: Bert Vermeulen , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, andy.shevchenko@gmail.com Subject: Re: [PATCH v2 0/1] spi: Add driver for Routerboard RB4xx boards Message-ID: <20150331142247.GG28951@linux-mips.org> References: <1427739857-13395-1-git-send-email-bert@biot.com> <20150331084425.GI2869@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150331084425.GI2869@sirena.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2015 at 09:44:25AM +0100, Mark Brown wrote: > On Mon, Mar 30, 2015 at 08:24:16PM +0200, Bert Vermeulen wrote: > > Changes in v2: > > This is a near complete rewrite of the original OpenWrt driver. All comments > > were taken into account, and the spi_transfer.fast_write flag is gone. > > Instead, the cs_change flag is used. It's not too bad a hack, as it really > > does use CS. > > Don't send cover letters for single patches, if there's anything that > needs saying it should either be in the changelog or after the ---. A > separate cover letter adds to the mail volume and probably means that > the patch itself is inadequately described. My personal grief with cover letters is that patchwork only collects patches but cover letters themselves aren't patches. Which means working through patchwork I might miss important information. Maybe I should request an enhancement to patchwork. Ralf