LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] caif: remove unused struct member
@ 2015-03-31 14:05 Rasmus Villemoes
  2015-04-01 16:43 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Rasmus Villemoes @ 2015-03-31 14:05 UTC (permalink / raw)
  To: Dmitry Tarnyagin; +Cc: Rasmus Villemoes, netdev, linux-kernel

The tty_name member of struct ser_device is never set or used, so it
can be removed. (The definition of struct ser_device is private to
this .c file, and the identifier tty_name only occurs in this one
place.)

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
 drivers/net/caif/caif_serial.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c
index 27bbc56de15f..9da06537237f 100644
--- a/drivers/net/caif/caif_serial.c
+++ b/drivers/net/caif/caif_serial.c
@@ -70,7 +70,6 @@ struct ser_device {
 	struct tty_struct *tty;
 	bool tx_started;
 	unsigned long state;
-	char *tty_name;
 #ifdef CONFIG_DEBUG_FS
 	struct dentry *debugfs_tty_dir;
 	struct debugfs_blob_wrapper tx_blob;
-- 
2.1.3


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] caif: remove unused struct member
  2015-03-31 14:05 [PATCH] caif: remove unused struct member Rasmus Villemoes
@ 2015-04-01 16:43 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-04-01 16:43 UTC (permalink / raw)
  To: linux; +Cc: dmitry.tarnyagin, netdev, linux-kernel

From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Date: Tue, 31 Mar 2015 16:05:23 +0200

> The tty_name member of struct ser_device is never set or used, so it
> can be removed. (The definition of struct ser_device is private to
> this .c file, and the identifier tty_name only occurs in this one
> place.)
> 
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-01 16:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-31 14:05 [PATCH] caif: remove unused struct member Rasmus Villemoes
2015-04-01 16:43 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).