LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Maxime Coquelin <maxime.coquelin@st.com>,
	Peter Griffin <peter.griffin@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com,
	patrice.chotard@st.com, balbi@ti.com, devicetree@vger.kernel.org,
	robherring2@gmail.com
Subject: Re: [PATCH v2 1/6] phy: miphy365x: Use the generic phy type constants in dt-bindings/phy/phy.h
Date: Wed, 1 Apr 2015 12:42:43 +0100	[thread overview]
Message-ID: <20150401114243.GV9447@x1> (raw)
In-Reply-To: <551BA5CB.6030903@ti.com>

On Wed, 01 Apr 2015, Kishon Vijay Abraham I wrote:

> Hi,
> 
> On Wednesday 01 April 2015 12:45 PM, Lee Jones wrote:
> >On Tue, 31 Mar 2015, Maxime Coquelin wrote:
> >
> >>Hi Kishon,
> >>On 03/31/2015 05:30 PM, Kishon Vijay Abraham I wrote:
> >>>Maxime,
> >>>
> >>>On Tuesday 31 March 2015 01:10 PM, Lee Jones wrote:
> >>>>On Tue, 31 Mar 2015, Kishon Vijay Abraham I wrote:
> >>>>
> >>>>>Hi Patrice, Maxime,
> >>>>>
> >>>>>On Monday 30 March 2015 08:47 PM, Peter Griffin wrote:
> >>>>>>Now there are generic phy type constants declared in phy.h,
> >>>>>>migrate over to
> >>>>>>using them rather than defining our own. This change has
> >>>>>>been done as one
> >>>>>>atomic commit to be bisectable.
> >>>>>>
> >>>>>>Note: The values of the defines are the same, so there is no
> >>>>>>ABI breakage
> >>>>>>with this patch.
> >>>>>>
> >>>>>>Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> >>>>>>Acked-by: Rob Herring <robh@kernel.org>
> >>>>>>Acked-by: Lee Jones <lee.jones@linaro.org>
> >>>>>
> >>>>>Are you okay for this patch to go via PHY tree? It modifies
> >>>>>arch/arm/boot/dts
> >>>>>/stih416.dtsi.
> >>>>
> >>>>These files need to be changed simultaneously in order to prevent
> >>>>breakage during bisection and the like.  I think the best bet moving
> >>>>forward is to pull this into its own branch, tag it and send Maxime a
> >>>>pull-request to the immutable branch.  It's the best way to minimise
> >>>>merge conflicts during the v4.1 merge window.
> >>>
> >>>okay. I still need an Ack from Maxime.
> >>
> >>You have my Ack.
> >>
> >>I haven't sent a pull request for STi DT files for v4.1 now, and it
> >>is too late to send one.
> >>So creating an immutable tag is not even needed in my opinion, you
> >>can just take the DT patch.
> >
> >Kishon,
> >
> >I saw that you took the MAINTAINERS patch, but not this one.  If it's
> >because you are still unsure about it, I agree with Maxime, you can
> >just take this patch without fear of conflict.
> 
> I've took this already
> https://git.kernel.org/cgit/linux/kernel/git/kishon/linux-phy.git/commit/?h=next&id=76fa6deabab05688a1653c2f66224be4a3c08d6a

I missed that.  Thanks for pointing it out.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2015-04-01 11:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 15:17 [PATCH v2 0/6] Add dwc3 usb3 DT node and various phy cleanup Peter Griffin
2015-03-30 15:17 ` [PATCH v2 1/6] phy: miphy365x: Use the generic phy type constants in dt-bindings/phy/phy.h Peter Griffin
2015-03-31  5:14   ` Kishon Vijay Abraham I
2015-03-31  7:40     ` Lee Jones
2015-03-31  8:01       ` Peter Griffin
2015-03-31  8:47         ` Lee Jones
2015-03-31 15:30       ` Kishon Vijay Abraham I
2015-03-31 15:55         ` Maxime Coquelin
2015-04-01  7:15           ` Lee Jones
2015-04-01  8:01             ` Kishon Vijay Abraham I
2015-04-01 11:42               ` Lee Jones [this message]
2015-03-30 15:17 ` [PATCH v2 2/6] ahci: st: Update the DT example for how to obtain the PHY Peter Griffin
2015-03-30 15:17 ` [PATCH v2 3/6] ARM: DT: STi: STiH407: Update picophyreset for the usb3 controllers usb2 phy Peter Griffin
2015-03-30 15:17 ` [PATCH v2 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node Peter Griffin
2015-03-30 15:17 ` [PATCH v2 5/6] usb: dwc3: dwc3-st: Update the incorrect DT dwc3 example Peter Griffin
2015-03-30 15:17 ` [PATCH v2 6/6] MAINTAINERS: Add phy-miphy28lp.c to ARCH/STI architecture Peter Griffin
2015-03-31 16:15   ` Kishon Vijay Abraham I
2015-03-31 17:40     ` Peter Griffin
2015-04-01  5:57       ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150401114243.GV9447@x1 \
    --to=lee.jones@linaro.org \
    --cc=balbi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.coquelin@st.com \
    --cc=patrice.chotard@st.com \
    --cc=peter.griffin@linaro.org \
    --cc=robherring2@gmail.com \
    --cc=srinivas.kandagatla@gmail.com \
    --subject='Re: [PATCH v2 1/6] phy: miphy365x: Use the generic phy type constants in dt-bindings/phy/phy.h' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).