From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752526AbbDBHN7 (ORCPT ); Thu, 2 Apr 2015 03:13:59 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35891 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467AbbDBHN5 (ORCPT ); Thu, 2 Apr 2015 03:13:57 -0400 Date: Thu, 2 Apr 2015 08:13:53 +0100 From: Lee Jones To: Ramakrishna Pallala Cc: linux-kernel@vger.kernel.org, MyungJoo Ham , Chanwoo Choi , Samuel Ortiz , Carlo Caione , Jacob Pan Subject: Re: [PATCH v1 1/2] mfd/axp20x: add support for extcon cell Message-ID: <20150402071353.GX9447@x1> References: <1427984131-22899-1-git-send-email-ramakrishna.pallala@intel.com> <1427984131-22899-2-git-send-email-ramakrishna.pallala@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1427984131-22899-2-git-send-email-ramakrishna.pallala@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 Apr 2015, Ramakrishna Pallala wrote: > This patch adds the mfd cell info for axp288 extcon device. > > Signed-off-by: Ramakrishna Pallala > --- > drivers/mfd/axp20x.c | 28 ++++++++++++++++++++++++++++ > include/linux/mfd/axp20x.h | 5 +++++ > 2 files changed, 33 insertions(+) [...] > diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h > index dfabd6d..4ed8071 100644 > --- a/include/linux/mfd/axp20x.h > +++ b/include/linux/mfd/axp20x.h > @@ -275,4 +275,9 @@ struct axp20x_fg_pdata { > int thermistor_curve[MAX_THERM_CURVE_SIZE][2]; > }; > > +struct axp288_extcon_pdata { > + /* GPIO pin control to switch D+/D- lines b/w PMIC and SOC */ > + struct gpio_desc *gpio_mux_cntl; > +}; This chunk of code is unrelated to this patch. ... and does it need to be in a struct of its own? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog