LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org,
mingo@redhat.com, lizefan@huawei.com, pi3orama@163.com,
linux-kernel@vger.kernel.org
Subject: [PATCH] perf kmem: Respect -i option
Date: Thu, 2 Apr 2015 10:24:24 +0200 [thread overview]
Message-ID: <20150402082424.GA1305@krava> (raw)
In-Reply-To: <1427954692-105642-1-git-send-email-wangnan0@huawei.com>
On Thu, Apr 02, 2015 at 06:04:52AM +0000, Wang Nan wrote:
> There is a bug in perf annotate that it doesn't respect user provided
> '-i'/'--input' option:
>
> # perf record ls
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.001 MB perf.data (8 samples) ]
> # mv ./perf.data ./perf.data.new
> # perf annotate -i ./perf.data.new --stdio
> failed to open perf.data: No such file or directory (try 'perf record' first)
>
> This patch fix it by setting file path after option parsing, like
> what 'perf report' does.
>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
plus found another in kmem.. ;-)
thanks,
jirka
---
Currently the perf kmem does not respect -i option.
Initializing the file.path properly after options
get parsed.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/builtin-kmem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
index 64d3623d45a0..c81e24870e7b 100644
--- a/tools/perf/builtin-kmem.c
+++ b/tools/perf/builtin-kmem.c
@@ -684,7 +684,6 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused)
};
struct perf_session *session;
struct perf_data_file file = {
- .path = input_name,
.mode = PERF_DATA_MODE_READ,
};
int ret = -1;
@@ -700,6 +699,8 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused)
return __cmd_record(argc, argv);
}
+ file.path = input_name;
+
session = perf_session__new(&file, false, &perf_kmem);
if (session == NULL)
return -1;
--
1.9.3
prev parent reply other threads:[~2015-04-02 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 6:04 [PATCH] perf: annotate: make it respect " Wang Nan
2015-04-02 8:12 ` Namhyung Kim
2015-04-21 3:06 ` Wang Nan
2015-04-02 8:24 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150402082424.GA1305@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
--subject='Re: [PATCH] perf kmem: Respect -i option' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).