LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-kernel@vger.kernel.org, nbd-general@lists.sourceforge.net,
	kernel@pengutronix.de
Subject: Re: [PATCH 7/9] nbd: Remove fixme that was already fixed
Date: Thu, 2 Apr 2015 02:05:34 -0700	[thread overview]
Message-ID: <20150402090534.GA8341@infradead.org> (raw)
In-Reply-To: <1427962301-17085-8-git-send-email-mpa@pengutronix.de>

On Thu, Apr 02, 2015 at 10:11:39AM +0200, Markus Pargmann wrote:
> +/*
> + * Forcibly shutdown the socket causing all listeners to error
> + */
>  static void sock_shutdown(struct nbd_device *nbd, int lock)
>  {
> -	/* Forcibly shutdown the socket causing all listeners
> -	 * to error
> -	 *
> -	 * FIXME: This code is duplicated from sys_shutdown, but
> -	 * there should be a more generic interface rather than
> -	 * calling socket ops directly here */
>  	if (lock)
>  		mutex_lock(&nbd->tx_lock);
>  	if (nbd->sock) {

Please also kill the conditional locking here in a future patch by
moving it into the caller.

  reply	other threads:[~2015-04-02  9:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02  8:11 [PULL] NBD patches for 4.1 Markus Pargmann
2015-04-02  8:11 ` [PATCH 1/9] Documentation: nbd: Reformat to allow more documentation Markus Pargmann
2015-04-02  8:11 ` [PATCH 2/9] Documentation: nbd: Add list of module parameters Markus Pargmann
2015-04-02  8:11 ` [PATCH 3/9] nbd: Remove kernel internal header Markus Pargmann
2015-04-02  8:11 ` [PATCH 4/9] nbd: Replace kthread_create with kthread_run Markus Pargmann
2015-04-02  8:11 ` [PATCH 5/9] nbd: Fix device bytesize type Markus Pargmann
2015-04-02  8:11 ` [PATCH 6/9] nbd: Restructure debugging prints Markus Pargmann
2015-04-02  8:11 ` [PATCH 7/9] nbd: Remove fixme that was already fixed Markus Pargmann
2015-04-02  9:05   ` Christoph Hellwig [this message]
2015-04-02  9:36     ` Markus Pargmann
2015-04-02  8:11 ` [PATCH 8/9] nbd: Return error code directly Markus Pargmann
2015-04-02  8:11 ` [PATCH 9/9] nbd: Return error pointer directly Markus Pargmann
2015-04-02 18:40 ` [PULL] NBD patches for 4.1 Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2015-02-12 20:57 [PATCH 0/9] nbd: cleanups Markus Pargmann
2015-02-12 20:57 ` [PATCH 7/9] nbd: Remove fixme that was already fixed Markus Pargmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150402090534.GA8341@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpa@pengutronix.de \
    --cc=nbd-general@lists.sourceforge.net \
    --subject='Re: [PATCH 7/9] nbd: Remove fixme that was already fixed' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).