From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753039AbbDBJgu (ORCPT ); Thu, 2 Apr 2015 05:36:50 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:51174 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752505AbbDBJgs (ORCPT ); Thu, 2 Apr 2015 05:36:48 -0400 Date: Thu, 2 Apr 2015 11:36:20 +0200 From: Markus Pargmann To: Christoph Hellwig Cc: Jens Axboe , linux-kernel@vger.kernel.org, nbd-general@lists.sourceforge.net, kernel@pengutronix.de Subject: Re: [PATCH 7/9] nbd: Remove fixme that was already fixed Message-ID: <20150402093620.GN11733@pengutronix.de> References: <1427962301-17085-1-git-send-email-mpa@pengutronix.de> <1427962301-17085-8-git-send-email-mpa@pengutronix.de> <20150402090534.GA8341@infradead.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7PAM/4G1BR2SfWzg" Content-Disposition: inline In-Reply-To: <20150402090534.GA8341@infradead.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:34:28 up 70 days, 23:41, 91 users, load average: 0.42, 0.44, 0.53 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7PAM/4G1BR2SfWzg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 02, 2015 at 02:05:34AM -0700, Christoph Hellwig wrote: > On Thu, Apr 02, 2015 at 10:11:39AM +0200, Markus Pargmann wrote: > > +/* > > + * Forcibly shutdown the socket causing all listeners to error > > + */ > > static void sock_shutdown(struct nbd_device *nbd, int lock) > > { > > - /* Forcibly shutdown the socket causing all listeners > > - * to error > > - * > > - * FIXME: This code is duplicated from sys_shutdown, but > > - * there should be a more generic interface rather than > > - * calling socket ops directly here */ > > if (lock) > > mutex_lock(&nbd->tx_lock); > > if (nbd->sock) { >=20 > Please also kill the conditional locking here in a future patch by > moving it into the caller. Yes, thanks. I will make a patch for that. Best Regards, Markus --=20 Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --7PAM/4G1BR2SfWzg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVHQ2UAAoJEEpcgKtcEGQQfncQAJLsjyvCaIknN2/WPtfYwhUU KLMdXUQhpin9deghnp25DzPMuUja+lA6MFVtzy1y4td8Qt1zuQSWoyVOqsfNUMhn uamiGUhD2DFQ/8Ko/klRld88YIzTyF3Sek6LLuP4bnHTNOqgVQcd24EYJYgRCSN8 SZnU9wA+i1LT9TbsF0R6gdT1Ujzdfw3fRWp3ND3hgU5icvVWNbkP4ocpjgJcDr3V lD9P1Ce5TqorU8ObJIQS82HcwYnXQlUDrCysBhv/ttw5OEV6zAJ722bRJGCON/JY BuulhM+/UkU2A8egoc3HQqxxuuUiBbh8lCbd4HEwyScay/TmbcDNttHdW4Sri2ZM tUDHCWMjHAy8KrhURyXoijPoblRzig2nZoYlp80KEOx9tGqSDdS8A2uhu2rIrBXK DSBct7bybl+Kyki2jpg4CxTAeiIEOKlv32B5TCYyIKuPOV6pw+iEy6mKhIHzWT4u lL4svmtwgyDexRVuh0pSOCtNuTuBOCES2bW5nuojPNOPlxrbJxyITyPI2LvA0b+r sA0foQhceWLfitlYIWWL/+UNmPp/5IFAQAdUXLujdarbuOHZaBEqMmLFjQKjHH2Q loP+Txv99glgRB0wTUq05Yqqaujb/apRQVNMmZg6O0J1y4CkTj8RuuB+2ntIOQBZ EKxzk0s6RmTpaxxhduXr =awMQ -----END PGP SIGNATURE----- --7PAM/4G1BR2SfWzg--