LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: "Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Carlo Caione <carlo@caione.org>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: Re: [PATCH v1 1/2] mfd/axp20x: add support for extcon cell
Date: Thu, 2 Apr 2015 11:54:53 +0100	[thread overview]
Message-ID: <20150402105453.GC9447@x1> (raw)
In-Reply-To: <D854C92F57B1B347B57E531E78D05EAD5780AB07@BGSMSX104.gar.corp.intel.com>

On Thu, 02 Apr 2015, Pallala, Ramakrishna wrote:

> Hi,
> 
> > > diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
> > > index dfabd6d..4ed8071 100644
> > > --- a/include/linux/mfd/axp20x.h
> > > +++ b/include/linux/mfd/axp20x.h
> > > @@ -275,4 +275,9 @@ struct axp20x_fg_pdata {
> > >  	int thermistor_curve[MAX_THERM_CURVE_SIZE][2];
> > >  };
> > >
> > > +struct axp288_extcon_pdata {
> > > +	/* GPIO pin control to switch D+/D- lines b/w PMIC and SOC */
> > > +	struct gpio_desc *gpio_mux_cntl;
> > > +};
> > 
> > This chunk of code is unrelated to this patch.
> As it's axp20x.h file change I added it here...if you don’t feel logical to have it in the patch I can move this to patch 2/2.

You should add it to the patch that first uses it.

> > ... and does it need to be in a struct of its own?
> Yes, I am planning to add another gpio control for VBUS boost.

Okay, thanks for clarifying.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2015-04-02 10:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02 14:15 [PATCH v1 0/2] Add extcon support for AXP288 PMIC Ramakrishna Pallala
2015-04-02 14:15 ` [PATCH v1 1/2] mfd/axp20x: add support for extcon cell Ramakrishna Pallala
2015-04-02  7:13   ` Lee Jones
2015-04-02  8:01     ` Pallala, Ramakrishna
2015-04-02 10:54       ` Lee Jones [this message]
2015-04-02 10:56         ` Pallala, Ramakrishna
2015-04-02 14:15 ` [PATCH v1 2/2] extcon-axp288: Add axp288 extcon driver support Ramakrishna Pallala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150402105453.GC9447@x1 \
    --to=lee.jones@linaro.org \
    --cc=carlo@caione.org \
    --cc=cw00.choi@samsung.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=ramakrishna.pallala@intel.com \
    --cc=sameo@linux.intel.com \
    --subject='Re: [PATCH v1 1/2] mfd/axp20x: add support for extcon cell' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).