LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Aaron Sierra <asierra@xes-inc.com>,
	Joe Schultz <jschultz@xes-inc.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: fsl_ifc_nand: use msecs_to_jiffies for time conversion
Date: Sun, 5 Apr 2015 18:05:50 -0700	[thread overview]
Message-ID: <20150406010550.GI2677@norris-Latitude-E6410> (raw)
In-Reply-To: <1426245828-15640-1-git-send-email-hofrat@osadl.org>

On Fri, Mar 13, 2015 at 07:23:47AM -0400, Nicholas Mc Guire wrote:
> This is only an API consolidation and should make things more readable
> it replaces var * HZ / 1000 by msecs_to_jiffies(var) which helps readability
> and also handles all corner-cases properly.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>

Pushed to l2-mtd.git.

I'm not sure the objections about an extra function call are important
right now; if they are, then it shouldn't be too hard to patch in a
__builtin_constant_p() variant of msecs_to_jiffies(), as Joe suggested.

Brian

      parent reply	other threads:[~2015-04-06  1:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13 11:23 Nicholas Mc Guire
2015-04-01 13:58 ` Aaron Sierra
2015-04-01 14:24   ` Nicholas Mc Guire
2015-04-01 15:08     ` Aaron Sierra
2015-04-01 15:18       ` Joe Perches
2015-04-02  0:20         ` Nicholas Mc Guire
2015-04-06  1:05 ` Brian Norris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150406010550.GI2677@norris-Latitude-E6410 \
    --to=computersforpeace@gmail.com \
    --cc=asierra@xes-inc.com \
    --cc=dwmw2@infradead.org \
    --cc=hofrat@osadl.org \
    --cc=jschultz@xes-inc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=wsa@the-dreams.de \
    --subject='Re: [PATCH] mtd: fsl_ifc_nand: use msecs_to_jiffies for time conversion' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).