LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Markus Pargmann <mpa@pengutronix.de>
To: Ingo Flaschberger <ingo.flaschberger@gmail.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] w1: gpio: Fix problematic platform_data usage
Date: Fri, 10 Apr 2015 12:22:12 +0200	[thread overview]
Message-ID: <20150410102212.GF11182@pengutronix.de> (raw)
In-Reply-To: <1425896338-31928-1-git-send-email-mpa@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

Hi,

On Mon, Mar 09, 2015 at 11:18:58AM +0100, Markus Pargmann wrote:
> pdev->dev.platform_data should not be overwritten by a driver. This
> patch fixes this issue by not using platform_get_pdata to get pdata. The
> DT routine can then simply return a pdata struct with those information.
> 
> Without this patch the platform_data may be freed twice, by devres and
> the driver framework.
> 
> Reported-by: Ingo Flaschberger <ingo.flaschberger@gmail.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>

Did you have time to test this? I would like to send this mainline but a
Tested-by of you would be nice.

Best Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-04-10 10:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04  3:53 unbind/bind w1-gpio with device tree produce a crash Ingo Flaschberger
2015-03-04 16:38 ` Ingo Flaschberger
     [not found]   ` <54F7C5D4.3000604@gmail.com>
2015-03-05  7:35     ` Fwd: " Markus Pargmann
2015-03-05 11:56       ` Ingo Flaschberger
2015-03-09 10:18         ` [PATCH] w1: gpio: Fix problematic platform_data usage Markus Pargmann
2015-04-10 10:22           ` Markus Pargmann [this message]
2016-03-22 11:59             ` Ingo Flaschberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150410102212.GF11182@pengutronix.de \
    --to=mpa@pengutronix.de \
    --cc=ingo.flaschberger@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --subject='Re: [PATCH] w1: gpio: Fix problematic platform_data usage' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).