LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Vinayak Holikatti <vinholikatti@gmail.com>,
	"James E.J. Bottomley" <JBottomley@parallels.com>,
	Mark Brown <broonie@kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH 2/5] ufs: Rename of regulator_set_optimum_mode
Date: Wed, 15 Apr 2015 11:35:16 -0700	[thread overview]
Message-ID: <20150415183516.GC29061@sonymobile.com> (raw)
In-Reply-To: <CAC5umyisp-aWU1mGajCCwS5yxaJvqh1UHUACEXb2ixHk5_+fJA@mail.gmail.com>

On Tue 14 Apr 05:11 PDT 2015, Akinobu Mita wrote:

> 2015-02-12 12:35 GMT+09:00 Bjorn Andersson <bjorn.andersson@sonymobile.com>:
> > The function regulator_set_optimum_mode() is changing name to
> > regulator_set_load(), so update the code accordingly. Also cleaned up
> > ufshcd_config_vreg_load() while touching the code.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>

[..]

> >  static inline int ufshcd_config_vreg_hpm(struct ufs_hba *hba,
> >                                          struct ufs_vreg *vreg)
> >  {
> > -       if (!vreg)
> > -               return 0;
> > -
> >         return ufshcd_config_vreg_load(hba->dev, vreg, vreg->max_uA);
> >  }
> 
> I tried this patch and it caused kernel null pointer dereference with
> 'verg->max_uA' when vreg == NULL.  So you can't simply move !vreg check here
> into ufshcd_config_vreg_load().

Akinobu-san, you're correct, sorry for missing that (and in essence
reverting your commit).

Looks like Linus merged the fix on master, so I will send out a fixup.

Regards,
Bjorn

  reply	other threads:[~2015-04-15 18:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12  3:35 [PATCH 0/5] Rename regulator_set_optimum_mode Bjorn Andersson
2015-02-12  3:35 ` [PATCH 1/5] regulator: " Bjorn Andersson
2015-02-12  3:35 ` [PATCH 2/5] ufs: Rename of regulator_set_optimum_mode Bjorn Andersson
2015-04-14 12:11   ` Akinobu Mita
2015-04-15 18:35     ` Bjorn Andersson [this message]
2015-02-12  3:35 ` [PATCH 3/5] usb: phy: ab8500-usb: Rename regulator_set_optimum_mode Bjorn Andersson
2015-02-27 15:29   ` Felipe Balbi
2015-02-12  3:35 ` [PATCH 4/5] usb: phy: phy-msm-usb: " Bjorn Andersson
2015-02-27 15:30   ` Felipe Balbi
2015-02-12  3:35 ` [PATCH 5/5] regulator: Drop temporary regulator_set_optimum_mode wrapper Bjorn Andersson
2015-02-25 23:40 ` [PATCH 0/5] Rename regulator_set_optimum_mode Bjorn Andersson
2015-03-05 10:46   ` Mark Brown
2015-03-09 18:33 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150415183516.GC29061@sonymobile.com \
    --to=bjorn.andersson@sonymobile.com \
    --cc=JBottomley@parallels.com \
    --cc=akinobu.mita@gmail.com \
    --cc=broonie@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=vinholikatti@gmail.com \
    --subject='Re: [PATCH 2/5] ufs: Rename of regulator_set_optimum_mode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).