LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Matthew Garrett <mjg59@coreos.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	kristen@linux.intel.com, Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH 1/3] libata: Stash initial power management configuration
Date: Tue, 21 Apr 2015 17:26:49 -0400	[thread overview]
Message-ID: <20150421212649.GH9455@htj.duckdns.org> (raw)
In-Reply-To: <1429370796-5881-2-git-send-email-mjg59@coreos.com>

Hello, Matthew.

On Sat, Apr 18, 2015 at 08:26:34AM -0700, Matthew Garrett wrote:
> @@ -313,6 +313,12 @@ struct ahci_port_priv {
>  	/* enclosure management info per PM slot */
>  	struct ahci_em_priv	em_priv[EM_MAX_SLOTS];
>  	char			*irq_desc;	/* desc in /proc/interrupts */

Can you please add a comment here referring to
ahci_setup_port_privdata()?

> +	bool			init_alpe;	/* alpe enabled by default */
> +	bool			init_asp;	/* asp enabled by default */
> +	bool			init_devslp;	/* devslp enabled by default */
> +	u32			init_dito;	/* initial dito configuration */
> +	u32			init_deto;	/* initial deto configuration */
> +	u32			init_mdat;	/* initial mdat configuration */
>  };
...
> +/*
> + * Allocate port privdata and read back initial power management configuration
> + */

And convert this to proper function comment which explains where it's
supposed to be called from and why it does what it does there?

> +int ahci_setup_port_privdata(struct ata_port *ap)
> +{
...
> @@ -5583,11 +5586,11 @@ void ata_link_init(struct ata_port *ap, struct ata_link *link, int pmp)
>  }
>  
>  /**
> - *	sata_link_init_spd - Initialize link->sata_spd_limit
> - *	@link: Link to configure sata_spd_limit for
> + *	sata_link_init_config - Initialize link->sata_spd_limit and init_lpm
> + *	@link: Link to configure sata_spd_limit and init_lpm for
>   *
> - *	Initialize @link->[hw_]sata_spd_limit to the currently
> - *	configured value.
> + *	Initialize @link->[hw_]sata_spd_limit and @link->init_lpm to the
> + *	currently configured value.

And I think it probably would be a better idea to make the libata core
dipm part a separate patch.

Other than that, looks good to me.

Thanks.

-- 
tejun

  reply	other threads:[~2015-04-21 21:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-18 15:26 Rework AHCI LPM handling a little Matthew Garrett
2015-04-18 15:26 ` [PATCH 1/3] libata: Stash initial power management configuration Matthew Garrett
2015-04-21 21:26   ` Tejun Heo [this message]
2015-04-18 15:26 ` [PATCH 2/3] libata: Add firmware_default LPM policy Matthew Garrett
2015-04-22 14:48   ` Tejun Heo
2015-05-11 20:24     ` Matthew Garrett
2015-05-11 20:28       ` Tejun Heo
2015-05-11 20:34         ` Matthew Garrett
2015-05-11 20:43           ` Tejun Heo
2015-04-18 15:26 ` [PATCH 3/3] libata: Change medium_power LPM policy to match Intel recommendations Matthew Garrett
2015-04-22 14:51   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150421212649.GH9455@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=kristen@linux.intel.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@coreos.com \
    --cc=mjg59@srcf.ucam.org \
    --subject='Re: [PATCH 1/3] libata: Stash initial power management configuration' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).