LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Matthew Garrett <mjg59@coreos.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	kristen@linux.intel.com
Subject: Re: [PATCH 2/3] libata: Add firmware_default LPM policy
Date: Wed, 22 Apr 2015 10:48:12 -0400	[thread overview]
Message-ID: <20150422144812.GA10592@htj.duckdns.org> (raw)
In-Reply-To: <1429370796-5881-3-git-send-email-mjg59@coreos.com>

Hello, Matthew.

On Sat, Apr 18, 2015 at 08:26:35AM -0700, Matthew Garrett wrote:
> +firmware_defaults	Inherit configuration from the state programmed by
> +			the firmware during system init.

Do we lose anything by naming the policy just "firmware"?

> @@ -701,9 +702,9 @@ static int ahci_set_lpm(struct ata_link *link, enum ata_lpm_policy policy,
>  
>  	if (hpriv->cap & HOST_CAP_ALPM) {
>  		u32 cmd = readl(port_mmio + PORT_CMD);
> +		cmd &= ~(PORT_CMD_ASP | PORT_CMD_ALPE);

Prolly worth nothing in the changelog?

>  
>  		if (policy == ATA_LPM_MAX_POWER || !(hints & ATA_LPM_HIPM)) {
> -			cmd &= ~(PORT_CMD_ASP | PORT_CMD_ALPE);
>  			cmd |= PORT_CMD_ICC_ACTIVE;
>  
>  			writel(cmd, port_mmio + PORT_CMD);
...
> @@ -2024,7 +2024,7 @@ retry:
>  		}
>  	}
>  
> -	if (id[79] & SATA_DIPM)
> +	if (id[79] & (1 << SATA_DIPM))
>  		dev->init_dipm = true;

Does this chunk belong here?

Thanks.

-- 
tejun

  reply	other threads:[~2015-04-22 14:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-18 15:26 Rework AHCI LPM handling a little Matthew Garrett
2015-04-18 15:26 ` [PATCH 1/3] libata: Stash initial power management configuration Matthew Garrett
2015-04-21 21:26   ` Tejun Heo
2015-04-18 15:26 ` [PATCH 2/3] libata: Add firmware_default LPM policy Matthew Garrett
2015-04-22 14:48   ` Tejun Heo [this message]
2015-05-11 20:24     ` Matthew Garrett
2015-05-11 20:28       ` Tejun Heo
2015-05-11 20:34         ` Matthew Garrett
2015-05-11 20:43           ` Tejun Heo
2015-04-18 15:26 ` [PATCH 3/3] libata: Change medium_power LPM policy to match Intel recommendations Matthew Garrett
2015-04-22 14:51   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150422144812.GA10592@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=kristen@linux.intel.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@coreos.com \
    --subject='Re: [PATCH 2/3] libata: Add firmware_default LPM policy' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).